]> xenbits.xensource.com Git - people/dariof/osstest.git/commitdiff
ts-host-install: include console before *and* after the -- marker.
authorIan Campbell <ian.campbell@citrix.com>
Wed, 29 Oct 2014 10:41:28 +0000 (10:41 +0000)
committerIan Campbell <ian.campbell@citrix.com>
Wed, 29 Oct 2014 16:49:14 +0000 (16:49 +0000)
As of v3.15 Linux now stop parsing its command line at the -- mark and passes
the remainder to init. This has broken Debian Installer's feature where
anything after the -- is propagated to the installed system.

See also https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=762007

To work around this we need to pass console= twice, once before the -- for the
current kernel's use and then again after the -- which is propagated to the
installed system.

Signed-off-by: Ian Campbell <ian.campbell@citrix.com>
Acked-by: Ian Jackson <ian.jackson@eu.citrix.com>
ts-host-install

index 881c2fd735c2bfb5e59e948005200cd0b1752d29..c611ed145a02135a84524ff9547c7eaf44750556 100755 (executable)
@@ -208,12 +208,16 @@ END
     push @installcmdline,
         get_host_property($ho, "install-append $ho->{Suite}", '');
 
-    push @installcmdline, qw(--);
-
     my $console = get_host_native_linux_console($ho);
 
     push @installcmdline, "console=$console" unless $console eq "NONE";
 
+    push @installcmdline, qw(--);
+
+    # See https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=762007 for
+    # why this is repeated.
+    push @installcmdline, "console=$console" unless $console eq "NONE";
+
     my $installcmdline= join ' ', @installcmdline;
 
     setup_pxeboot($ho, <<END);