]> xenbits.xensource.com Git - qemu-xen.git/commitdiff
Revert "hw/versatile: realize the PCI root bus as part of the versatile init"
authorMarkus Armbruster <armbru@redhat.com>
Wed, 10 Jun 2020 05:31:52 +0000 (07:31 +0200)
committerMarkus Armbruster <armbru@redhat.com>
Mon, 15 Jun 2020 19:36:30 +0000 (21:36 +0200)
This reverts commit b1af7959a66610669e1a019b9a84f6ed3a7936c6.

Realizing a device automatically realizes its buses, in
device_set_realized().  Realizing them in realize methods is
redundant, unless the methods themselves require them to be realized
early.  pci_vpb_realize() doesn't.  Drop the redundant bus
realization.

Cc: Marcel Apfelbaum <marcel.apfelbaum@gmail.com>
Cc: Michael S. Tsirkin <mst@redhat.com>
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Paolo Bonzini <pbonzini@redhat.com>
Message-Id: <20200610053247.1583243-4-armbru@redhat.com>

hw/pci-host/versatile.c

index 8ddfb8772a2c4e6fb524b7d2b5d77c059ec5d7fc..ea7390c6fae62d9cbcd36525e286f1b178c53311 100644 (file)
@@ -459,7 +459,6 @@ static void pci_vpb_realize(DeviceState *dev, Error **errp)
     }
 
     /* TODO Remove once realize propagates to child devices. */
-    object_property_set_bool(OBJECT(&s->pci_bus), true, "realized", errp);
     object_property_set_bool(OBJECT(&s->pci_dev), true, "realized", errp);
 }