]> xenbits.xensource.com Git - people/aperard/linux.git/commitdiff
ARM: OMAP2+: Add missing put_device() call in omapdss_init_of()
authorMarkus Elfring <elfring@users.sourceforge.net>
Sat, 9 Nov 2019 16:19:35 +0000 (17:19 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sun, 26 Jan 2020 09:00:58 +0000 (10:00 +0100)
commit 0b491904f053e41685162af5c5411b85b18c97a7 upstream.

A coccicheck run provided information like the following.

arch/arm/mach-omap2/display.c:268:2-8: ERROR: missing put_device;
call of_find_device_by_node on line 258, but without a corresponding
object release within this function.

Generated by: scripts/coccinelle/free/put_device.cocci

Thus add the missed function call to fix the exception handling for
this function implementation.

Fixes: e0c827aca0730b51f38081aa4e8ecf0912aab55f ("drm/omap: Populate DSS children in omapdss driver")
Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
Signed-off-by: Tony Lindgren <tony@atomide.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
arch/arm/mach-omap2/display.c

index 439e143cad7b5d4d8ef48122816f9acf436570c3..46012ca812f484126d90012a60e0127c9979c0fc 100644 (file)
@@ -265,6 +265,7 @@ static int __init omapdss_init_of(void)
        r = of_platform_populate(node, NULL, NULL, &pdev->dev);
        if (r) {
                pr_err("Unable to populate DSS submodule devices\n");
+               put_device(&pdev->dev);
                return r;
        }