]> xenbits.xensource.com Git - qemu-xen.git/commitdiff
libvhost-user: Zero memory allocated for VuVirtqInflightDesc
authorXie Yongji <xieyongji@baidu.com>
Tue, 19 Nov 2019 07:57:59 +0000 (15:57 +0800)
committerMichael S. Tsirkin <mst@redhat.com>
Wed, 20 Nov 2019 09:57:22 +0000 (04:57 -0500)
Use a zero-initialized VuVirtqInflightDesc struct to avoid
that scan-build reports that vq->resubmit_list[0].counter may
be garbage value in vu_check_queue_inflights().

Fixes: 5f9ff1eff ("libvhost-user: Support tracking inflight I/O in
shared memory")
Reported-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Signed-off-by: Xie Yongji <xieyongji@baidu.com>
Message-Id: <20191119075759.4334-1-xieyongji@baidu.com>
Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
contrib/libvhost-user/libvhost-user.c

index 68c27136aed5ddc18447255738cb423479640f88..ec27b78ff108dfdb08e6b6495efd83006a433b40 100644 (file)
@@ -992,7 +992,7 @@ vu_check_queue_inflights(VuDev *dev, VuVirtq *vq)
     vq->shadow_avail_idx = vq->last_avail_idx = vq->inuse + vq->used_idx;
 
     if (vq->inuse) {
-        vq->resubmit_list = malloc(sizeof(VuVirtqInflightDesc) * vq->inuse);
+        vq->resubmit_list = calloc(vq->inuse, sizeof(VuVirtqInflightDesc));
         if (!vq->resubmit_list) {
             return -1;
         }