]> xenbits.xensource.com Git - libvirt.git/commitdiff
qemu: process: Report better error when virtlogd connection fails
authorPeter Krempa <pkrempa@redhat.com>
Tue, 11 Jun 2019 11:58:29 +0000 (13:58 +0200)
committerPeter Krempa <pkrempa@redhat.com>
Thu, 20 Jun 2019 15:10:24 +0000 (17:10 +0200)
When connecting to virtlogd fails e.g. due to wrong libvirtd selinux
process label we'd report an utterly useless error message:

$ virsh start upstream
error: Failed to start domain upstream
error: Cannot recv data: Connection reset by peer

Use virLastErrorPrefixMessage in the correct place to give a better
sense of what's going on:

$ virsh start upstream
error: Failed to start domain upstream
error: can't connect to virtlogd: Cannot recv data: Connection reset by peer

Signed-off-by: Peter Krempa <pkrempa@redhat.com>
ACKed-by: Michal Privoznik <mprivozn@redhat.com>
src/qemu/qemu_process.c

index c9f8a0f311fbc73fd673307b36a68495485072cd..86cfeeb6f01a551bcb992b217143e2a338c7e16a 100644 (file)
@@ -6641,8 +6641,10 @@ qemuProcessLaunch(virConnectPtr conn,
 
     VIR_DEBUG("Creating domain log file");
     if (!(logCtxt = qemuDomainLogContextNew(driver, vm,
-                                            QEMU_DOMAIN_LOG_CONTEXT_MODE_START)))
+                                            QEMU_DOMAIN_LOG_CONTEXT_MODE_START))) {
+        virLastErrorPrefixMessage("%s", _("can't connect to virtlogd"));
         goto cleanup;
+    }
     logfile = qemuDomainLogContextGetWriteFD(logCtxt);
 
     if (qemuProcessGenID(vm, flags) < 0)