]> xenbits.xensource.com Git - qemu-upstream-4.3-testing.git/commitdiff
xilinx_axidma: (un)reversed irq initialisation
authorPeter A. G. Crosthwaite <peter.crosthwaite@petalogix.com>
Wed, 13 Jun 2012 04:46:50 +0000 (14:46 +1000)
committerEdgar E. Iglesias <edgar.iglesias@gmail.com>
Fri, 15 Jun 2012 11:08:13 +0000 (13:08 +0200)
The axidma irq orders are reversed in both the device model and the instantion.
Undid both reversal (for no net change). Also needs to be reversed for
consistency with Xilinx tools IRQ listing.

Signed-off-by: Peter A. G. Crosthwaite <peter.crosthwaite@petalogix.com>
Signed-off-by: Edgar E. Iglesias <edgar.iglesias@gmail.com>
hw/xilinx.h
hw/xilinx_axidma.c

index 35f35bd7fc1f957086dad04af7f8578d85f51b69..70d15cfcf9d0acb72feef67c7b7d5ceb1b836249 100644 (file)
@@ -81,8 +81,8 @@ xilinx_axiethernetdma_create(void *dmach,
     qdev_init_nofail(dev);
 
     sysbus_mmio_map(sysbus_from_qdev(dev), 0, base);
-    sysbus_connect_irq(sysbus_from_qdev(dev), 0, irq2);
-    sysbus_connect_irq(sysbus_from_qdev(dev), 1, irq);
+    sysbus_connect_irq(sysbus_from_qdev(dev), 0, irq);
+    sysbus_connect_irq(sysbus_from_qdev(dev), 1, irq2);
 
     return dev;
 }
index 85dfcbf2b9ad47663202e748a1dc2a175a89551b..59373b51d98de1eb1f3159dd1781f62ff1526d8c 100644 (file)
@@ -463,8 +463,8 @@ static int xilinx_axidma_init(SysBusDevice *dev)
     struct XilinxAXIDMA *s = FROM_SYSBUS(typeof(*s), dev);
     int i;
 
-    sysbus_init_irq(dev, &s->streams[1].irq);
     sysbus_init_irq(dev, &s->streams[0].irq);
+    sysbus_init_irq(dev, &s->streams[1].irq);
 
     if (!s->dmach) {
         hw_error("Unconnected DMA channel.\n");