]> xenbits.xensource.com Git - qemu-xen.git/commitdiff
error: Fix "Converting to ERRP_GUARD()" doc on "valid at return"
authorMarkus Armbruster <armbru@redhat.com>
Mon, 25 Jan 2021 13:26:35 +0000 (14:26 +0100)
committerMarkus Armbruster <armbru@redhat.com>
Fri, 5 Mar 2021 14:40:42 +0000 (15:40 +0100)
Setting errp = NULL is wrong: the automatic error propagation still
propagates the dangling pointer _auto_errp_prop.local_err.  We need to
set *errp = NULL to clear the dangling pointer.

Signed-off-by: Markus Armbruster <armbru@redhat.com>
Message-Id: <20210125132635.1253219-1-armbru@redhat.com>
Reviewed-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
include/qapi/error.h

index eaa05c48374cb9aaa689f6984e56e8a1eb190da5..4a9260b0cc00d411128320e16351dfd0a66eb53e 100644 (file)
  *    error_propagate_prepend(errp, *errp, ...) by error_prepend(errp, ...)
  *
  * 4. Ensure @errp is valid at return: when you destroy *errp, set
- *    errp = NULL.
+ *    *errp = NULL.
  *
  * Example:
  *