]> xenbits.xensource.com Git - libvirt.git/commitdiff
network: add debug when bandwidth settings are not applied
authorDaniel P. Berrangé <berrange@redhat.com>
Fri, 13 Sep 2019 16:04:41 +0000 (17:04 +0100)
committerDaniel P. Berrangé <berrange@redhat.com>
Fri, 13 Sep 2019 16:34:09 +0000 (17:34 +0100)
To aid in troubleshooting add some debug messages wrt
bandwidth settings and networks.

Reviewed-by: Laine Stump <laine@laine.org>
Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
src/network/bridge_driver.c

index 6a97bb17e2c0a62a0edfb75ad9f62824a678ac83..c54be964077a250d922cdc5539296587a10fbf48 100644 (file)
@@ -5192,9 +5192,14 @@ networkCheckBandwidth(virNetworkObjPtr obj,
         return -1;
     }
 
+    if (!netBand || !netBand->in) {
+        VIR_DEBUG("No network bandwidth controls present");
+        /* no QoS required, claim success */
+        return 1;
+    }
     if (((!ifaceBand || !ifaceBand->in || !ifaceBand->in->floor) &&
-         (!oldBandwidth || !oldBandwidth->in || !oldBandwidth->in->floor)) ||
-        !netBand || !netBand->in) {
+         (!oldBandwidth || !oldBandwidth->in || !oldBandwidth->in->floor))) {
+        VIR_DEBUG("No old/new interface bandwidth floor");
         /* no QoS required, claim success */
         return 1;
     }