]> xenbits.xensource.com Git - libvirt.git/commitdiff
qemu: avoid dead store in doPeer2PeerMigrate3
authorAlex Jia <ajia@redhat.com>
Tue, 16 Aug 2011 09:24:25 +0000 (17:24 +0800)
committerEric Blake <eblake@redhat.com>
Thu, 25 Aug 2011 19:28:08 +0000 (13:28 -0600)
* src/qemu/qemu_migration.c: avoid dead 'ret' assignment and silence
  clang warning.

Detected by ccc-analyzer:

  CC     libvirt_driver_qemu_la-qemu_migration.lo
qemu/qemu_migration.c:2046:5: warning: Value stored to 'ret' is never read
    ret = qemuMigrationConfirm(driver, sconn, vm,
    ^     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

src/qemu/qemu_migration.c

index a84faf68fd4f36152a9ae263cc2240ee929a57d7..64459ec0cace2304de922680eecb778be3d933af 100644 (file)
@@ -2043,6 +2043,9 @@ finish:
      * do, but fortunately worst case is that there is a
      * domain left in 'paused' state on source.
      */
+    if (ret < 0)
+        VIR_WARN("Guest %s probably left in 'paused' state on source",
+                 vm->def->name);
 
  cleanup:
     if (ddomain) {