]> xenbits.xensource.com Git - libvirt.git/commitdiff
qemu: Unlink temporary file on failure
authorMichal Privoznik <mprivozn@redhat.com>
Tue, 2 Aug 2011 15:50:18 +0000 (17:50 +0200)
committerEric Blake <eblake@redhat.com>
Tue, 2 Aug 2011 16:21:08 +0000 (10:21 -0600)
Although virFDStreamOpenFile will unlink it once opened, when we hit
error path, we must unlink it by hand.

src/qemu/qemu_driver.c

index 09b2791be66309f9579ea4e2c0a2397d3cbf81d3..5e2c903f6077ee562e0e50a29a87d00f374f233e 100644 (file)
@@ -2931,7 +2931,10 @@ qemuDomainScreenshot(virDomainPtr dom,
 
 endjob:
     VIR_FORCE_CLOSE(tmp_fd);
-    VIR_FREE(tmp);
+    if (tmp) {
+        unlink(tmp);
+        VIR_FREE(tmp);
+    }
 
     if (qemuDomainObjEndJob(driver, vm) == 0)
         vm = NULL;