]> xenbits.xensource.com Git - libvirt.git/commitdiff
Fix a misuse of virAsprintf in qemudDomainMemoryPeek
authorRyota Ozaki <ozaki.ryota@gmail.com>
Fri, 14 May 2010 10:08:59 +0000 (19:08 +0900)
committerEric Blake <eblake@redhat.com>
Fri, 14 May 2010 16:45:58 +0000 (10:45 -0600)
The code specifies driver->cacheDir as the format string,
but it usually doesn't contain '%s', so the subsequent
argument, "/qemu.mem.XXXXXX", is always ignored.

The patch fixes the misuse.

src/qemu/qemu_driver.c

index d6a34564f0724961a7732249c31c642fb1bcf7db..0b297fd8b1d12918b75096f5b0f0b25fc6bd82a1 100644 (file)
@@ -9177,7 +9177,7 @@ qemudDomainMemoryPeek (virDomainPtr dom,
         goto endjob;
     }
 
-    if (virAsprintf(&tmp, driver->cacheDir,  "/qemu.mem.XXXXXX") < 0) {
+    if (virAsprintf(&tmp, "%s/qemu.mem.XXXXXX", driver->cacheDir) < 0) {
         virReportOOMError();
         goto endjob;
     }