]> xenbits.xensource.com Git - libvirt.git/commitdiff
qemu: monitor: Drop support for old-style non-shared storage migration
authorPeter Krempa <pkrempa@redhat.com>
Thu, 8 Sep 2022 10:54:57 +0000 (12:54 +0200)
committerPeter Krempa <pkrempa@redhat.com>
Fri, 9 Sep 2022 14:10:47 +0000 (16:10 +0200)
Remove the support for enabling the 'blk' and 'inc' parameters of the
'migrate' command as there are no users any more.

Signed-off-by: Peter Krempa <pkrempa@redhat.com>
Reviewed-by: Ján Tomko <jtomko@redhat.com>
src/qemu/qemu_monitor.h
src/qemu/qemu_monitor_json.c
tests/qemumonitorjsontest.c

index 63269e15bcc56e419305710e90abb799bf726594..53ea26c58a2d11f65d4476c90be5b81ed8796739 100644 (file)
@@ -826,8 +826,6 @@ int qemuMonitorGetSEVCapabilities(qemuMonitor *mon,
 
 typedef enum {
   QEMU_MONITOR_MIGRATE_BACKGROUND       = 1 << 0,
-  QEMU_MONITOR_MIGRATE_NON_SHARED_DISK  = 1 << 1, /* migration with non-shared storage with full disk copy */
-  QEMU_MONITOR_MIGRATE_NON_SHARED_INC   = 1 << 2, /* migration with non-shared storage with incremental copy */
   QEMU_MONITOR_MIGRATE_RESUME           = 1 << 3, /* resume failed post-copy migration */
   QEMU_MONITOR_MIGRATION_FLAGS_LAST
 } QEMU_MONITOR_MIGRATE;
index 70fba50e6c3d439c96d1a09baa46b6a4604e5b71..bf22cc64f826928a9dcd747c7b75ef13846c23e5 100644 (file)
@@ -3110,13 +3110,9 @@ int qemuMonitorJSONMigrate(qemuMonitor *mon,
                            const char *uri)
 {
     bool detach = !!(flags & QEMU_MONITOR_MIGRATE_BACKGROUND);
-    bool blk = !!(flags & QEMU_MONITOR_MIGRATE_NON_SHARED_DISK);
-    bool inc = !!(flags & QEMU_MONITOR_MIGRATE_NON_SHARED_INC);
     bool resume = !!(flags & QEMU_MONITOR_MIGRATE_RESUME);
     g_autoptr(virJSONValue) cmd = qemuMonitorJSONMakeCommand("migrate",
                                                              "b:detach", detach,
-                                                             "b:blk", blk,
-                                                             "b:inc", inc,
                                                              "b:resume", resume,
                                                              "s:uri", uri,
                                                              NULL);
index b508f63aea2fec32f1c37fa03c3ff6380f2cc894..fa5455e513d907e48afb3ce920ff0fd6fe197e7a 100644 (file)
@@ -1201,9 +1201,7 @@ GEN_TEST_FUNC(qemuMonitorJSONExpirePassword, "spice", "123456")
 GEN_TEST_FUNC(qemuMonitorJSONSetBalloon, 1024)
 GEN_TEST_FUNC(qemuMonitorJSONSaveVirtualMemory, 0, 1024, "/foo/bar")
 GEN_TEST_FUNC(qemuMonitorJSONSavePhysicalMemory, 0, 1024, "/foo/bar")
-GEN_TEST_FUNC(qemuMonitorJSONMigrate, QEMU_MONITOR_MIGRATE_BACKGROUND |
-              QEMU_MONITOR_MIGRATE_NON_SHARED_DISK |
-              QEMU_MONITOR_MIGRATE_NON_SHARED_INC, "tcp:localhost:12345")
+GEN_TEST_FUNC(qemuMonitorJSONMigrate, QEMU_MONITOR_MIGRATE_BACKGROUND, "tcp:localhost:12345")
 GEN_TEST_FUNC(qemuMonitorJSONMigrateRecover, "tcp://destination.host:54321");
 GEN_TEST_FUNC(qemuMonitorJSONDump, "dummy_protocol", "elf",
               true)