]> xenbits.xensource.com Git - libvirt.git/commitdiff
Revert "qemu: Allow to plug virtio-net-pci into PCIe slot"
authorLaine Stump <laine@laine.org>
Tue, 11 Aug 2015 23:07:53 +0000 (19:07 -0400)
committerLaine Stump <laine@laine.org>
Wed, 12 Aug 2015 15:23:29 +0000 (11:23 -0400)
This reverts commit ede34470fde19c0f326cdb0dfca39fa86fd9ec16, which
was apparently written based on testing performed before commits
1e15be1 and 9a12b6 were pushed upstream. Once those two patches are in
place, commit ede34470 is redundant, and can even cause
incorrect/unexpected behavior when auto-assigning addresses for
virtio-net devices.

src/qemu/qemu_command.c

index 84cbfe1b4def25e62092bdc8a74fb4a66f3499f9..0d7b1559a5f68f3048ee605e67e145ea2fb16f73 100644 (file)
@@ -1680,14 +1680,6 @@ qemuCollectPCIAddress(virDomainDefPtr def ATTRIBUTE_UNUSED,
          */
         flags = VIR_PCI_CONNECT_TYPE_PCI | VIR_PCI_CONNECT_TYPE_PCIE;
         break;
-
-    case VIR_DOMAIN_DEVICE_NET:
-        if (STREQ(device->data.net->model, "virtio")) {
-            /* virtio-net-pci adapter in qemu has to be plugged into PCIe slot
-             * in order to be able to use irqfds with vhost-net
-             */
-            flags = VIR_PCI_CONNECT_TYPE_PCI | VIR_PCI_CONNECT_TYPE_PCIE;
-        }
     }
 
     /* Ignore implicit controllers on slot 0:0:1.0: