]> xenbits.xensource.com Git - xen.git/commitdiff
memory: fix compat handling of XENMEM_access_op
authorJan Beulich <jbeulich@suse.com>
Tue, 6 Sep 2016 10:13:43 +0000 (12:13 +0200)
committerJan Beulich <jbeulich@suse.com>
Tue, 6 Sep 2016 10:13:43 +0000 (12:13 +0200)
Within compat_memory_op() this needs to be placed in the first switch()
statement, or it ends up being dead code (as that first switch() has a
default case chaining to compat_arch_memory_op()).

Signed-off-by: Jan Beulich <jbeulich@suse.com>
Tested-by: Razvan Cojocaru <rcojocaru@bitdefender.com>
Reviewed-by: Andrew Cooper <andrew.cooper3@citrix.com>
master commit: 8d6af808a7e9d9ae1d129e1e5a0def7f8b2333ee
master date: 2016-09-02 14:19:51 +0200

xen/common/compat/memory.c

index b2581380f3ad98a86ecbca529e697a260aa688cf..9ddac5a1f9603b78fe77e4402e0278532402b4f1 100644 (file)
@@ -276,6 +276,11 @@ int compat_memory_op(unsigned int cmd, XEN_GUEST_HANDLE_PARAM(void) compat)
             break;
         }
 
+        case XENMEM_access_op:
+            return mem_access_memop(cmd,
+                                    guest_handle_cast(compat,
+                                                      xen_mem_access_op_t));
+
         case XENMEM_get_vnumainfo:
         {
             enum XLAT_vnuma_topology_info_vdistance vdistance =
@@ -422,10 +427,6 @@ int compat_memory_op(unsigned int cmd, XEN_GUEST_HANDLE_PARAM(void) compat)
             break;
         }
 
-        case XENMEM_access_op:
-            rc = mem_access_memop(cmd, guest_handle_cast(compat, xen_mem_access_op_t));
-            break;
-
         case XENMEM_add_to_physmap_batch:
             start_extent = end_extent;
             break;