]> xenbits.xensource.com Git - people/gdunlap/xen.git/commitdiff
xen/arm: timer: Don't warn if the timer interrupts are high-level
authorJulien Grall <julien.grall@linaro.org>
Mon, 2 Mar 2015 15:54:57 +0000 (15:54 +0000)
committerIan Campbell <ian.campbell@citrix.com>
Mon, 2 Mar 2015 17:02:12 +0000 (17:02 +0000)
The commit 61d6a84 "xen: arm: Warn if timer interrupts are not level
triggered" added a check to ensure the timer interrupts are level.

Although, the check is only done on low-level interrupts. This will
result to a strange warning on platform using high-level ("WARNING [..]
IRQ is not level triggered").

As high-level interrupt is valid, don't warn on both high-level and
low-level interrupt.

Signed-off-by: Julien Grall <julien.grall@linaro.org>
Acked-by: Ian Campbell <ian.campbell@citrix.com>
xen/arch/arm/time.c

index 8977cce33b665761b72925741f4ec066d9e88c54..352e25e78643cc5c88b1fe3fe089a89b9bd7637f 100644 (file)
@@ -217,7 +217,7 @@ static void check_timer_irq_cfg(unsigned int irq, const char *which)
      * The interrupt controller driver will update desc->arch.type with
      * the actual type which ended up configured in the hardware.
      */
-    if ( desc->arch.type & DT_IRQ_TYPE_LEVEL_LOW )
+    if ( desc->arch.type & DT_IRQ_TYPE_LEVEL_MASK )
         return;
 
     printk(XENLOG_WARNING