]> xenbits.xensource.com Git - libvirt.git/commitdiff
qemu: driver: Don't try to update blockjob status in qemuDomainGetBlockJobInfo
authorPeter Krempa <pkrempa@redhat.com>
Wed, 15 May 2019 09:10:16 +0000 (11:10 +0200)
committerPeter Krempa <pkrempa@redhat.com>
Tue, 21 May 2019 12:22:05 +0000 (14:22 +0200)
All blockjobs get their status updated by events from qemu, so this code
no longer makes sense.

Signed-off-by: Peter Krempa <pkrempa@redhat.com>
Reviewed-by: Ján Tomko <jtomko@redhat.com>
src/qemu/qemu_driver.c

index 9c0796b0a4cbe744ecee459574a5c68f81d579bd..4766bc12993612324f157ba4685d846374e00422 100644 (file)
@@ -17442,20 +17442,6 @@ qemuDomainGetBlockJobInfo(virDomainPtr dom,
         goto endjob;
     }
 
-    /* Snoop block copy operations, so future cancel operations can
-     * avoid checking if pivot is safe.  Save the change to XML, but
-     * we can ignore failure because it is only an optimization.  We
-     * hold the vm lock, so modifying the in-memory representation is
-     * safe, even if we are a query rather than a modify job. */
-    if (disk->mirror &&
-        rawInfo.ready != 0 &&
-        info->cur == info->end && !disk->mirrorState) {
-        virQEMUDriverConfigPtr cfg = virQEMUDriverGetConfig(driver);
-
-        disk->mirrorState = VIR_DOMAIN_DISK_MIRROR_STATE_READY;
-        ignore_value(virDomainSaveStatus(driver->xmlopt, cfg->stateDir, vm, driver->caps));
-        virObjectUnref(cfg);
-    }
  endjob:
     qemuDomainObjEndJob(driver, vm);