]> xenbits.xensource.com Git - people/dariof/libvirt.git/commitdiff
qemu: check if block I/O limits fit into long long
authorJán Tomko <jtomko@redhat.com>
Mon, 24 Jun 2013 12:18:14 +0000 (14:18 +0200)
committerJán Tomko <jtomko@redhat.com>
Mon, 24 Jun 2013 12:18:14 +0000 (14:18 +0200)
We can only pass values up to LLONG_MAX through JSON
and QEMU checks if the int64_t number is not negative
at startup since 1.5.0.

https://bugzilla.redhat.com/show_bug.cgi?id=974010

src/qemu/qemu_driver.c

index 3d9457f00f456924e8e0d4dd0dd9d0a4c2a9f27b..b4b66aa808553134de072820415112b797b93ac7 100644 (file)
@@ -14099,6 +14099,13 @@ qemuDomainSetBlockIoTune(virDomainPtr dom,
     for (i = 0; i < nparams; i++) {
         virTypedParameterPtr param = &params[i];
 
+        if (param->value.ul > LLONG_MAX) {
+            virReportError(VIR_ERR_OVERFLOW,
+                           _("block I/O throttle limit value must"
+                             " be less than %llu"), LLONG_MAX);
+            goto endjob;
+        }
+
         if (STREQ(param->field, VIR_DOMAIN_BLOCK_IOTUNE_TOTAL_BYTES_SEC)) {
             info.total_bytes_sec = param->value.ul;
             set_bytes = true;