]> xenbits.xensource.com Git - libvirt.git/commitdiff
qemu: remove unnecessary virBufferFreeAndReset() after virCommandAddArgBuffer()
authorLaine Stump <laine@redhat.com>
Sat, 4 Jul 2020 21:45:57 +0000 (17:45 -0400)
committerLaine Stump <laine@redhat.com>
Wed, 8 Jul 2020 20:34:55 +0000 (16:34 -0400)
The latter function is guaranteed to always clear out the virBuffer
anyway, so this is redundant and could add to extra cargo-cult code if
used as an example.

Signed-off-by: Laine Stump <laine@redhat.com>
Reviewed-by: Ján Tomko <jtomko@redhat.com>
src/qemu/qemu_command.c

index f86f32639d80785e02ec406b4c2911e84cd8e520..6dbaf40f1e6585a399f3d47b709d9ab6ce78ebca 100644 (file)
@@ -9080,7 +9080,6 @@ qemuBuldDomainLoaderPflashCommandLine(virCommandPtr cmd,
     virCommandAddArgBuffer(cmd, &buf);
 
     if (loader->nvram) {
-        virBufferFreeAndReset(&buf);
         virBufferAddLit(&buf, "file=");
         virQEMUBuildBufferEscapeComma(&buf, loader->nvram);
         virBufferAsprintf(&buf, ",if=pflash,format=raw,unit=%d", unit);