]> xenbits.xensource.com Git - xen.git/commitdiff
xen/arm32: __cmpxchg_mb should be marked always_inline
authorJulien Grall <julien.grall@linaro.org>
Thu, 3 Apr 2014 17:09:10 +0000 (18:09 +0100)
committerIan Campbell <ian.campbell@citrix.com>
Tue, 8 Apr 2014 14:52:44 +0000 (15:52 +0100)
Currently __cmpxchg_mb is only marked inline. The compiler can decide to not
inline this function. In this case, the call to __cmpxchg will be inlined
but not optimised. This will result linking failure because of __bad_cmpxchg.

Caught by clang 3.5.

Signed-off-by: Julien Grall <julien.grall@linaro.org>
Acked-by: Ian Campbell <ian.campbell@citrix.com>
xen/include/asm-arm/arm32/cmpxchg.h

index 70c6090cc139a4bd206b785aba28ec64e5fdef4b..3f4e7a15eedfe25f17609fa0a606edf38826d027 100644 (file)
@@ -112,8 +112,9 @@ static always_inline unsigned long __cmpxchg(
        return oldval;
 }
 
-static inline unsigned long __cmpxchg_mb(volatile void *ptr, unsigned long old,
-                                        unsigned long new, int size)
+static always_inline unsigned long __cmpxchg_mb(volatile void *ptr,
+                                                unsigned long old,
+                                                unsigned long new, int size)
 {
        unsigned long ret;