]> xenbits.xensource.com Git - people/dariof/xen.git/commitdiff
x86/IRQ: make fixup_irqs() skip unconnected internally used interrupts
authorJan Beulich <jbeulich@suse.com>
Mon, 22 Jul 2019 09:45:58 +0000 (11:45 +0200)
committerJan Beulich <jbeulich@suse.com>
Mon, 22 Jul 2019 09:45:58 +0000 (11:45 +0200)
Since the "Cannot set affinity ..." warning is a one time one, avoid
triggering it already at boot time when parking secondary threads and
the serial console uses a (still unconnected at that time) PCI IRQ.

Signed-off-by: Jan Beulich <jbeulich@suse.com>
Reviewed-by: Roger Pau Monné <roger.pau@citrix.com>
Acked-by: Andrew Cooper <andrew.cooper3@citrix.com>
xen/arch/x86/irq.c

index f5e31a1c9bf4a0782de4ab51d94ae6901d2559ae..abd773f35d8ef5759bb55707cfea84a934425adf 100644 (file)
@@ -2464,8 +2464,20 @@ void fixup_irqs(const cpumask_t *mask, bool verbose)
         vector = irq_to_vector(irq);
         if ( vector >= FIRST_HIPRIORITY_VECTOR &&
              vector <= LAST_HIPRIORITY_VECTOR )
+        {
             cpumask_and(desc->arch.cpu_mask, desc->arch.cpu_mask, mask);
 
+            /*
+             * This can in particular happen when parking secondary threads
+             * during boot and when the serial console wants to use a PCI IRQ.
+             */
+            if ( desc->handler == &no_irq_type )
+            {
+                spin_unlock(&desc->lock);
+                continue;
+            }
+        }
+
         if ( desc->arch.move_cleanup_count )
         {
             /* The cleanup IPI may have got sent while we were still online. */