qemu: Allow setting pinning of emulator/iohtread with automatic placement

We honour the placement bitmaps when starting up, so there's no point in
having this check. Additionally the check was buggy since it checked
vm->def all the time even if the user requested to modify the persistent
definition which had different configuration.

Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1308317

diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c
index 75f447dede584b1ebb098789cdd46789ace31460..8a529afa3a9fa13f091160c7dada0684a643844d 100644 (file)
--- a/src/qemu/qemu_driver.c
+++ b/src/qemu/qemu_driver.c
@@ -5240,13 +5240,6 @@ qemuDomainPinEmulator(virDomainPtr dom,
     if (virDomainPinEmulatorEnsureACL(dom->conn, vm->def, flags) < 0)
         goto cleanup;
 
-    if (vm->def->placement_mode == VIR_DOMAIN_CPU_PLACEMENT_MODE_AUTO) {
-        virReportError(VIR_ERR_OPERATION_INVALID, "%s",
-                       _("Changing affinity for emulator thread dynamically "
-                         "is not allowed when CPU placement is 'auto'"));
-        goto cleanup;
-    }
-
     if (qemuDomainObjBeginJob(driver, vm, QEMU_JOB_MODIFY) < 0)
         goto cleanup;
 
@@ -5714,13 +5707,6 @@ qemuDomainPinIOThread(virDomainPtr dom,
     if (virDomainPinIOThreadEnsureACL(dom->conn, vm->def, flags) < 0)
         goto cleanup;
 
-    if (vm->def->placement_mode == VIR_DOMAIN_CPU_PLACEMENT_MODE_AUTO) {
-        virReportError(VIR_ERR_OPERATION_INVALID, "%s",
-                       _("Changing affinity for IOThread dynamically is "
-                         "not allowed when CPU placement is 'auto'"));
-        goto cleanup;
-    }
-
     if (qemuDomainObjBeginJob(driver, vm, QEMU_JOB_MODIFY) < 0)
         goto cleanup;