x86: Fix atomic_write*() macros to correctly inform GCC that memory

it knows about is being written to.

The bug is a copy-and-paste error from inline asm that writes to I/O
memory. In that case, as with asm for accessign guest memory,
specifying memory as a read-only parameter is acceptable because the
memory cannot alias with anything that GCC reads directly.

Signed-off-by: Keir Fraser <keir@xen.org>
xen-unstable changeset:   22683:533d6e5c0099
xen-unstable date:        Sat Jan 08 10:05:55 2011 +0000

diff --git a/xen/include/asm-x86/atomic.h b/xen/include/asm-x86/atomic.h
index 345880fd12b4f97219fd24c3ca072175f498d327..446b969e2f5450df3f8027ef5f9b2015ca6bc036 100644 (file)
--- a/xen/include/asm-x86/atomic.h
+++ b/xen/include/asm-x86/atomic.h
@@ -17,8 +17,8 @@ static inline type name(const volatile type *addr) \
 
 #define build_atomic_write(name, size, type, reg, barrier) \
 static inline void name(volatile type *addr, type val) \
-{ asm volatile("mov" size " %0,%1": :reg (val), \
-"m" (*(volatile type *)addr) barrier); }
+{ asm volatile("mov" size " %1,%0": "=m" (*(volatile type *)addr) \
+:reg (val) barrier); }
 
 build_atomic_read(atomic_read8, "b", uint8_t, "=q", )
 build_atomic_read(atomic_read16, "w", uint16_t, "=r", )