]> xenbits.xensource.com Git - people/liuw/libxenctrl-split/libvirt.git/commitdiff
qemu: Separate char device removal into a standalone function
authorJiri Denemark <jdenemar@redhat.com>
Tue, 16 Jul 2013 19:16:09 +0000 (21:16 +0200)
committerJiri Denemark <jdenemar@redhat.com>
Thu, 18 Jul 2013 13:18:04 +0000 (15:18 +0200)
src/qemu/qemu_hotplug.c

index a98de9d253d5a7fbc4f30fe4590821199042522a..54b4c82d0eef861f2a28961d381b6f3f0127a60c 100644 (file)
@@ -2475,6 +2475,19 @@ qemuDomainRemoveHostDevice(virQEMUDriverPtr driver,
 }
 
 
+static void
+qemuDomainRemoveChrDevice(virQEMUDriverPtr driver ATTRIBUTE_UNUSED,
+                          virDomainObjPtr vm,
+                          virDomainChrDefPtr chr)
+{
+    VIR_DEBUG("Removing character device %s from domain %p %s",
+              chr->info.alias, vm, vm->def->name);
+
+    qemuDomainChrRemove(vm->def, chr);
+    virDomainChrDefFree(chr);
+}
+
+
 int qemuDomainDetachVirtioDiskDevice(virQEMUDriverPtr driver,
                                      virDomainObjPtr vm,
                                      virDomainDiskDefPtr detach)
@@ -3170,8 +3183,7 @@ int qemuDomainDetachChrDevice(virQEMUDriverPtr driver,
     }
     qemuDomainObjExitMonitor(driver, vm);
 
-    qemuDomainChrRemove(vmdef, tmpChr);
-    virDomainChrDefFree(tmpChr);
+    qemuDomainRemoveChrDevice(driver, vm, tmpChr);
     ret = 0;
 
 cleanup: