Fix crash in virsh connect command

diff --git a/ChangeLog b/ChangeLog
index 62f6a72799cce7bbd3f814531393fd12c19912d4..6b690de7dba99a2adf8fb954d7d3fdceddfe5e66 100644 (file)
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,9 +1,14 @@
+Mon Jan 22 15:41:52 EST 2007 Daniel Berrange <berrange@redhat.com>
+
+       * src/virsh.c: Fix crash in 'connect' command by ensuring
+       we always strdup the connection URI string.
+
 Mon Jan 22 16:23:52 IST 2007 Mark McLoughlin <markmc@redhat.com>
 
        * src/internal.h: virDomain.handle refers to the "id"
        in the API, so re-name to virDomain.id to avoid
        confusion.
-       
+
        * src/hash.c, src/libvirt.c, src/proxy_internal.c, src/test.c,
        src/xen_internal.c, src/xend_internal.c, src/xm_internal.c,
        src/xml.c, src/xs_internal.c: update for rename.

diff --git a/src/virsh.c b/src/virsh.c
index 30b5c6b1de5df3a185f53a49e9d0b14586cca4a7..b04f88e13704627072e9fdc58a8fd1b8a3a29128 100644 (file)
--- a/src/virsh.c
+++ b/src/virsh.c
@@ -292,7 +292,7 @@ cmdConnect(vshControl * ctl, vshCmd * cmd)
     
     if (ctl->name)
         free(ctl->name);
-    ctl->name = vshCommandOptString(cmd, "name", NULL);
+    ctl->name = vshStrdup(ctl, vshCommandOptString(cmd, "name", NULL));
 
     if (!ro)
         ctl->conn = virConnectOpen(ctl->name);