]> xenbits.xensource.com Git - unikraft/unikraft.git/commitdiff
lib/posix-process: remove clone3 syscall
authorIoan-Teodor Teugea <teodor.teugea@gmail.com>
Wed, 19 Apr 2023 11:29:10 +0000 (14:29 +0300)
committerUnikraft <monkey@unikraft.io>
Thu, 4 May 2023 12:20:14 +0000 (12:20 +0000)
As clone3 currently does not work, and glibc falls
back to clone if clone3 is not available (tested on 2.35),
the syscall can be removed until a working implementation is
available.

Signed-off-by: Ioan-Teodor Teugea <teodor.teugea@gmail.com>
Reviewed-by: Florin Postolache <florin.postolache.of@gmail.com>
Reviewed-by: Simon Kuenzer <simon@unikraft.io>
Approved-by: Simon Kuenzer <simon@unikraft.io>
Tested-by: Unikraft CI <monkey@unikraft.io>
GitHub-Closes: #847

lib/posix-process/Makefile.uk
lib/posix-process/clone.c

index 6139b7059a077086e646b3846a2a371506158fe6..7a1dbbd523a36ab447d5ebd6523f07b63bea9e86 100644 (file)
@@ -17,7 +17,6 @@ LIBPOSIX_PROCESS_SRCS-$(CONFIG_LIBPOSIX_PROCESS_CLONE) += $(LIBPOSIX_PROCESS_BAS
 COMPFLAGS-$(CONFIG_LIBPOSIX_PROCESS_PIDS) += -fno-builtin-exit -fno-builtin-exit-group
 
 UK_PROVIDED_SYSCALLS-$(CONFIG_LIBPOSIX_PROCESS_CLONE) += clone-5
-UK_PROVIDED_SYSCALLS-$(CONFIG_LIBPOSIX_PROCESS_CLONE) += clone3-2
 UK_PROVIDED_SYSCALLS-$(CONFIG_LIBPOSIX_PROCESS) += execve-3
 UK_PROVIDED_SYSCALLS-$(CONFIG_LIBPOSIX_PROCESS) += wait4-4 waitid-4
 UK_PROVIDED_SYSCALLS-$(CONFIG_LIBPOSIX_PROCESS) += getpgid-1
index d9ae00840d046886cca2eb5f7fc935506fce0f22..56a14e7750be0f4f6210d7580c8dc88439cfbc31 100644 (file)
@@ -528,14 +528,6 @@ int clone(int (*fn)(void *) __unused, void *sp __unused,
 }
 #endif /* UK_LIBC_SYSCALLS */
 
-/* NOTE: There are currently no libc wrapper for clone3 */
-UK_LLSYSCALL_R_DEFINE(long, clone3,
-                     struct clone_args *, cl_args,
-                     size_t, cl_args_len)
-{
-       return _clone(cl_args, cl_args_len, uk_syscall_return_addr());
-}
-
 /*
  * Checks that the CLONE_VM is set so that we make sure that
  * the address space is shared. Unikraft does currently not support