]> xenbits.xensource.com Git - qemu-xen.git/commitdiff
block: Use block_job_add_bdrv() in mirror_start_job()
authorAlberto Garcia <berto@igalia.com>
Fri, 28 Oct 2016 07:08:05 +0000 (10:08 +0300)
committerKevin Wolf <kwolf@redhat.com>
Mon, 31 Oct 2016 15:52:38 +0000 (16:52 +0100)
Use block_job_add_bdrv() instead of blocking all operations in
mirror_start_job() and unblocking them in mirror_exit().

Signed-off-by: Alberto Garcia <berto@igalia.com>
Reviewed-by: Kevin Wolf <kwolf@redhat.com>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
block/mirror.c

index 3a0788ede37059d09a4103f3a3f9c01b538970e7..04765ad2ffadfa223dfb2fe08d4e12e3c3319268 100644 (file)
@@ -530,7 +530,6 @@ static void mirror_exit(BlockJob *job, void *opaque)
         aio_context_release(replace_aio_context);
     }
     g_free(s->replaces);
-    bdrv_op_unblock_all(target_bs, s->common.blocker);
     blk_unref(s->target);
     s->target = NULL;
     block_job_completed(&s->common, data->ret);
@@ -997,7 +996,7 @@ static void mirror_start_job(const char *job_id, BlockDriverState *bs,
         return;
     }
 
-    bdrv_op_block_all(target, s->common.blocker);
+    block_job_add_bdrv(&s->common, target);
 
     s->common.co = qemu_coroutine_create(mirror_run, s);
     trace_mirror_start(bs, s, s->common.co, opaque);