]> xenbits.xensource.com Git - libvirt.git/commitdiff
qemumonitorjsontest: Drop 'schema-meta' case
authorPeter Krempa <pkrempa@redhat.com>
Mon, 22 May 2023 11:17:17 +0000 (13:17 +0200)
committerPeter Krempa <pkrempa@redhat.com>
Mon, 5 Jun 2023 11:20:12 +0000 (13:20 +0200)
The test case is validating the QMP schema against itself. This was
useful when I was developing the validator but at this point it's no
longer needed.

Additionally the QMP schema has few deprecated members now, which our
validator doesn't catch yet, so this test would start failing once I fix
the validator.

Signed-off-by: Peter Krempa <pkrempa@redhat.com>
Reviewed-by: Ján Tomko <jtomko@redhat.com>
tests/qemumonitorjsontest.c

index d9323d94c3f76f4bf609e19841b5bab06e90828f..c3963050de8031f9ed40a2981e66b2a72049a75b 100644 (file)
@@ -2825,8 +2825,6 @@ mymain(void)
     g_autoptr(GHashTable) qapischema_x86_64 = NULL;
     g_autoptr(GHashTable) qapischema_s390x = NULL;
     struct testQAPISchemaData qapiData;
-    g_autoptr(virJSONValue) metaschema = NULL;
-    g_autofree char *metaschemastr = NULL;
 
     if (qemuTestDriverInit(&driver) < 0)
         return EXIT_FAILURE;
@@ -3047,17 +3045,6 @@ mymain(void)
     DO_TEST_QAPI_VALIDATE("alternate 2", "blockdev-add/arg-type", false,
                           "{\"driver\":\"qcow2\",\"file\": 1234}");
 
-    if (!(metaschema = testQEMUSchemaGetLatest("x86_64")) ||
-        !(metaschemastr = virJSONValueToString(metaschema, false))) {
-        VIR_TEST_VERBOSE("failed to load latest qapi schema");
-        ret = -1;
-        goto cleanup;
-    }
-
-    DO_TEST_QAPI_VALIDATE("schema-meta", "query-qmp-schema/ret-type", true,
-                        metaschemastr);
-
-
 #undef DO_TEST_QAPI_VALIDATE
 
     if (virTestRun("validate that object-add and device_add don't have schema",