check-spacing: rewrite regex for checking the closing parenthesis

Instead of matching multiple characters before the parenthesis,
only check for a single whitespace, which is much less cpu-intensive.

This only matches a few dozen of places where they are on an separate
line, filter out those with a separate regex.

diff --git a/build-aux/check-spacing.pl b/build-aux/check-spacing.pl
index d693fbe572298eabb3f8d7b7d6ccd621e2e7e1a6..7c5bbf9e51cf1011cdf9fe82d94d0b0d84e7ea68 100755 (executable)
--- a/build-aux/check-spacing.pl
+++ b/build-aux/check-spacing.pl
@@ -118,7 +118,9 @@ foreach my $file (@ARGV) {
         }
 
         # Forbid whitespace following ( or prior to )
-        if ($data =~ /\S\s+\)/ ||
+        # but allow whitespace before ) on a single line
+        # (optionally followed by a semicolon)
+        if (($data =~ /\s\)/ && not $data =~ /^\s+\);?$/) ||
             $data =~ /\(\s+\S/) {
             print "Whitespace after '(' or before ')':\n";
             print "$file:$.: $line";