]> xenbits.xensource.com Git - xen.git/commitdiff
x86/vpmu: address violations of MISRA C Rule 16.3
authorFederico Serafini <federico.serafini@bugseng.com>
Tue, 30 Jul 2024 09:52:47 +0000 (11:52 +0200)
committerJan Beulich <jbeulich@suse.com>
Tue, 30 Jul 2024 09:52:47 +0000 (11:52 +0200)
Add missing break statements to address violations of MISRA C Rule
16.3: "An unconditional `break' statement shall terminate every
switch-clause".

No functional change.

Signed-off-by: Federico Serafini <federico.serafini@bugseng.com>
Reviewed-by: Stefano Stabellini <sstabellini@kernel.org>
Reviewed-by: Jan Beulich <jbeulich@suse.com>
xen/arch/x86/cpu/vpmu.c
xen/arch/x86/cpu/vpmu_intel.c

index a7bc0cd1fcab5c94612e137dda09aa25c42fa258..b2ba9994129ba5b79552797cb116d44d8b1d0b91 100644 (file)
@@ -663,6 +663,8 @@ long do_xenpmu_op(
 
         if ( pmu_params.version.maj != XENPMU_VER_MAJ )
             return -EINVAL;
+
+        break;
     }
 
     switch ( op )
@@ -776,6 +778,7 @@ long do_xenpmu_op(
 
     default:
         ret = -EINVAL;
+        break;
     }
 
     return ret;
index cd414165dfce3adfe4494cfc435c1c62a4978060..26dd3a935821c6a38b468a19706fb6bb4b3beae4 100644 (file)
@@ -666,6 +666,7 @@ static int cf_check core2_vpmu_do_wrmsr(unsigned int msr, uint64_t msr_content)
 
             xen_pmu_cntr_pair[tmp].control = msr_content;
         }
+        break;
     }
 
     if ( type != MSR_TYPE_GLOBAL )
@@ -713,6 +714,7 @@ static int cf_check core2_vpmu_do_rdmsr(unsigned int msr, uint64_t *msr_content)
             break;
         default:
             rdmsrl(msr, *msr_content);
+            break;
         }
     }
     else if ( msr == MSR_IA32_MISC_ENABLE )