]> xenbits.xensource.com Git - people/vhanquez/xen.git/commitdiff
hvm: Fix is_isa_irq_masked().
authorKeir Fraser <keir.fraser@citrix.com>
Wed, 12 Dec 2007 14:32:10 +0000 (14:32 +0000)
committerKeir Fraser <keir.fraser@citrix.com>
Wed, 12 Dec 2007 14:32:10 +0000 (14:32 +0000)
Incorrectly it was not checking whether the vlapic is masking the pic.

Signed-off-by: Dexuan Cui <dexuan.cui@intel.com>
xen-unstable changeset:   16594:686b75b31f3cc10453119dd23eac4e7ac3f9e9ad
xen-unstable date:        Wed Dec 12 10:40:02 2007 +0000

xen/arch/x86/hvm/irq.c

index 6b5f387b0c8dcbe98f6f689ce56542ca10cb19c1..b2433478af5de32381b5fbeee95dca7ca0f50912 100644 (file)
@@ -328,12 +328,13 @@ int get_isa_irq_vector(struct vcpu *v, int isa_irq, int type)
 int is_isa_irq_masked(struct vcpu *v, int isa_irq)
 {
     unsigned int gsi = hvm_isa_irq_to_gsi(isa_irq);
+    uint8_t pic_imr;
 
     if ( is_lvtt(v, isa_irq) )
         return !is_lvtt_enabled(v);
 
-    return ((v->domain->arch.hvm_domain.vpic[isa_irq >> 3].imr &
-             (1 << (isa_irq & 7))) &&
+    pic_imr = v->domain->arch.hvm_domain.vpic[isa_irq >> 3].imr;
+    return (((pic_imr & (1 << (isa_irq & 7))) || !vlapic_accept_pic_intr(v)) &&
             domain_vioapic(v->domain)->redirtbl[gsi].fields.mask);
 }