]> xenbits.xensource.com Git - libvirt.git/commitdiff
qemu: deprecate QEMU_CAPS_MEM_PATH
authorJán Tomko <jtomko@redhat.com>
Thu, 29 Mar 2018 10:46:23 +0000 (12:46 +0200)
committerJán Tomko <jtomko@redhat.com>
Thu, 12 Apr 2018 15:17:17 +0000 (17:17 +0200)
Implied by QEMU >= 1.2.0.

Signed-off-by: Ján Tomko <jtomko@redhat.com>
Reviewed-by: Andrea Bolognani <abologna@redhat.com>
29 files changed:
src/qemu/qemu_capabilities.c
src/qemu/qemu_capabilities.h
src/qemu/qemu_command.c
tests/qemucapabilitiesdata/caps_1.5.3.x86_64.xml
tests/qemucapabilitiesdata/caps_1.6.0.x86_64.xml
tests/qemucapabilitiesdata/caps_1.7.0.x86_64.xml
tests/qemucapabilitiesdata/caps_2.1.1.x86_64.xml
tests/qemucapabilitiesdata/caps_2.10.0.aarch64.xml
tests/qemucapabilitiesdata/caps_2.10.0.ppc64.xml
tests/qemucapabilitiesdata/caps_2.10.0.s390x.xml
tests/qemucapabilitiesdata/caps_2.10.0.x86_64.xml
tests/qemucapabilitiesdata/caps_2.11.0.s390x.xml
tests/qemucapabilitiesdata/caps_2.12.0.aarch64.xml
tests/qemucapabilitiesdata/caps_2.12.0.ppc64.xml
tests/qemucapabilitiesdata/caps_2.12.0.s390x.xml
tests/qemucapabilitiesdata/caps_2.12.0.x86_64.xml
tests/qemucapabilitiesdata/caps_2.4.0.x86_64.xml
tests/qemucapabilitiesdata/caps_2.5.0.x86_64.xml
tests/qemucapabilitiesdata/caps_2.6.0.aarch64.xml
tests/qemucapabilitiesdata/caps_2.6.0.ppc64.xml
tests/qemucapabilitiesdata/caps_2.6.0.x86_64.xml
tests/qemucapabilitiesdata/caps_2.7.0.s390x.xml
tests/qemucapabilitiesdata/caps_2.7.0.x86_64.xml
tests/qemucapabilitiesdata/caps_2.8.0.s390x.xml
tests/qemucapabilitiesdata/caps_2.8.0.x86_64.xml
tests/qemucapabilitiesdata/caps_2.9.0.ppc64.xml
tests/qemucapabilitiesdata/caps_2.9.0.s390x.xml
tests/qemucapabilitiesdata/caps_2.9.0.x86_64.xml
tests/qemuxml2argvtest.c

index b8cf303f31fc2cc50e03059ff361bcf4e1bf7249..b41955a7d08bb811d67aacc3afc94c32df24b9f2 100644 (file)
@@ -3637,7 +3637,6 @@ static qemuMonitorCallbacks callbacks = {
 static void
 virQEMUCapsInitQMPBasic(virQEMUCapsPtr qemuCaps)
 {
-    virQEMUCapsSet(qemuCaps, QEMU_CAPS_MEM_PATH);
     virQEMUCapsSet(qemuCaps, QEMU_CAPS_DRIVE_SERIAL);
     virQEMUCapsSet(qemuCaps, QEMU_CAPS_SDL);
     virQEMUCapsSet(qemuCaps, QEMU_CAPS_RTC);
index c80f531a342001bcc6350257710bb9989a9e7d94..cb588886c680265a87e5ade8f7c97e52e73d29fd 100644 (file)
@@ -72,7 +72,7 @@ typedef enum {
     X_QEMU_CAPS_VGA, /* Is -vga avail */
     X_QEMU_CAPS_0_10, /* features added in qemu-0.10.0 or later */
     X_QEMU_CAPS_PCIDEVICE, /* PCI device assignment supported */
-    QEMU_CAPS_MEM_PATH, /* mmap'ped guest backing supported */
+    X_QEMU_CAPS_MEM_PATH, /* mmap'ped guest backing supported */
     QEMU_CAPS_DRIVE_SERIAL, /* -driver serial=  available */
 
     /* 20 */
index 28deed3e6f245750653b99aa84bcdda07f34f713..5b42b8c98dee82a721777ae986674a26d1b5368e 100644 (file)
@@ -7464,7 +7464,6 @@ qemuBuildSmpCommandLine(virCommandPtr cmd,
 static int
 qemuBuildMemPathStr(virQEMUDriverConfigPtr cfg,
                     const virDomainDef *def,
-                    virQEMUCapsPtr qemuCaps,
                     virCommandPtr cmd)
 {
     const long system_page_size = virGetSystemPageSizeKB();
@@ -7483,13 +7482,6 @@ qemuBuildMemPathStr(virQEMUDriverConfigPtr cfg,
     if (def->mem.hugepages[0].size == system_page_size)
         return 0;
 
-    if (!virQEMUCapsGet(qemuCaps, QEMU_CAPS_MEM_PATH)) {
-        virReportError(VIR_ERR_INTERNAL_ERROR,
-                       _("hugepage backing not supported by '%s'"),
-                       def->emulator);
-        return -1;
-    }
-
     if (qemuGetDomainHupageMemPath(def, cfg, def->mem.hugepages[0].size, &mem_path) < 0)
         return -1;
 
@@ -7534,7 +7526,7 @@ qemuBuildMemCommandLine(virCommandPtr cmd,
      * the hugepages and no numa node is specified.
      */
     if (!virDomainNumaGetNodeCount(def->numa) &&
-        qemuBuildMemPathStr(cfg, def, qemuCaps, cmd) < 0)
+        qemuBuildMemPathStr(cfg, def, cmd) < 0)
         return -1;
 
     if (def->mem.locked && !virQEMUCapsGet(qemuCaps, QEMU_CAPS_REALTIME_MLOCK)) {
@@ -7664,7 +7656,7 @@ qemuBuildNumaArgStr(virQEMUDriverConfigPtr cfg,
     }
 
     if (!needBackend &&
-        qemuBuildMemPathStr(cfg, def, qemuCaps, cmd) < 0)
+        qemuBuildMemPathStr(cfg, def, cmd) < 0)
         goto cleanup;
 
     for (i = 0; i < ncells; i++) {
index 8ded417088b977fd16c39176f7624a240d28a8c9..891cb25e8b7c1fd7631c216a1c7d6666de6fd1e0 100644 (file)
@@ -4,7 +4,6 @@
   <selfvers>0</selfvers>
   <usedQMP/>
   <flag name='kvm'/>
-  <flag name='mem-path'/>
   <flag name='drive-serial'/>
   <flag name='sdl'/>
   <flag name='rtc'/>
index 6fcc7f1c5722faee60a7c94be69d231242cdd5cd..2d9b18c72ab58d6c51b25aa44087e3681888b2f8 100644 (file)
@@ -4,7 +4,6 @@
   <selfvers>0</selfvers>
   <usedQMP/>
   <flag name='kvm'/>
-  <flag name='mem-path'/>
   <flag name='drive-serial'/>
   <flag name='sdl'/>
   <flag name='rtc'/>
index 58227aca1b09f09e47c4852ee87428e95a398bc2..dbe56d74655507697dc860568c1dcb2dd9773fd7 100644 (file)
@@ -4,7 +4,6 @@
   <selfvers>0</selfvers>
   <usedQMP/>
   <flag name='kvm'/>
-  <flag name='mem-path'/>
   <flag name='drive-serial'/>
   <flag name='sdl'/>
   <flag name='rtc'/>
index 3a06c764201cde2b6592a366f59d6b7635db5e75..4f4399c7d237d64961cc577c2aec40ce85c95f65 100644 (file)
@@ -4,7 +4,6 @@
   <selfvers>0</selfvers>
   <usedQMP/>
   <flag name='kvm'/>
-  <flag name='mem-path'/>
   <flag name='drive-serial'/>
   <flag name='sdl'/>
   <flag name='rtc'/>
index c13d96c2365da2cf17a3cfe9b385e21b91cb437f..325850bcbbe2d93509c39d85d5b6c871180728c5 100644 (file)
@@ -4,7 +4,6 @@
   <selfvers>0</selfvers>
   <usedQMP/>
   <flag name='kvm'/>
-  <flag name='mem-path'/>
   <flag name='drive-serial'/>
   <flag name='sdl'/>
   <flag name='rtc'/>
index 4097f89d09a22a5de591d5da30594b769ed88386..41959fdb96abcc0b5c1aceb6b8e5c398719dded9 100644 (file)
@@ -4,7 +4,6 @@
   <selfvers>0</selfvers>
   <usedQMP/>
   <flag name='kvm'/>
-  <flag name='mem-path'/>
   <flag name='drive-serial'/>
   <flag name='sdl'/>
   <flag name='rtc'/>
index 7a3292ee85749828a57658562892183ee4b1fac2..9d6c57d8b8bfe19cf7c79d542a0ecc6f54ba7c78 100644 (file)
@@ -4,7 +4,6 @@
   <selfvers>0</selfvers>
   <usedQMP/>
   <flag name='kvm'/>
-  <flag name='mem-path'/>
   <flag name='drive-serial'/>
   <flag name='sdl'/>
   <flag name='rtc'/>
index 02cb1aca776f11c67d6f75dc597505a6f23b4de0..1203958b0a06b9ff8befee555f79719f048cf3c2 100644 (file)
@@ -4,7 +4,6 @@
   <selfvers>0</selfvers>
   <usedQMP/>
   <flag name='kvm'/>
-  <flag name='mem-path'/>
   <flag name='drive-serial'/>
   <flag name='sdl'/>
   <flag name='rtc'/>
index 9137af24faf9c0c13a6370b845b424e617da6294..a2ea35f2e81e5f3a60e2492284564171653dfb9b 100644 (file)
@@ -4,7 +4,6 @@
   <selfvers>0</selfvers>
   <usedQMP/>
   <flag name='kvm'/>
-  <flag name='mem-path'/>
   <flag name='drive-serial'/>
   <flag name='sdl'/>
   <flag name='rtc'/>
index e5675ae4d2538ee02a8100b0876d7cae0da55189..45a81de582838170d356348d740ba1d37f528a93 100644 (file)
@@ -4,7 +4,6 @@
   <selfvers>0</selfvers>
   <usedQMP/>
   <flag name='kvm'/>
-  <flag name='mem-path'/>
   <flag name='drive-serial'/>
   <flag name='sdl'/>
   <flag name='rtc'/>
index 0216a12852c5a3716787d8e4542541198374a3cc..8eb6f802316e048f06a140b083279d060c78f884 100644 (file)
@@ -4,7 +4,6 @@
   <selfvers>0</selfvers>
   <usedQMP/>
   <flag name='kvm'/>
-  <flag name='mem-path'/>
   <flag name='drive-serial'/>
   <flag name='sdl'/>
   <flag name='rtc'/>
index 1be024cc7caa1f3f0bf9833c2ab24ec2113cd34d..16f4c4e3548550bbb9260b5b698d81e2eff99aaf 100644 (file)
@@ -3,7 +3,6 @@
   <selfctime>0</selfctime>
   <selfvers>0</selfvers>
   <usedQMP/>
-  <flag name='mem-path'/>
   <flag name='drive-serial'/>
   <flag name='enable-kvm'/>
   <flag name='sdl'/>
index 1b81499b966e4ecb169a0f1c92eeb33f6b4e1ec8..54971485c15eb344b8ff68d2277beb294b4a567b 100644 (file)
@@ -4,7 +4,6 @@
   <selfvers>0</selfvers>
   <usedQMP/>
   <flag name='kvm'/>
-  <flag name='mem-path'/>
   <flag name='drive-serial'/>
   <flag name='sdl'/>
   <flag name='rtc'/>
index 8c9afec91c16245c1ab84b141144364cd2b93779..1ad8ce62c6646b3754ff664fd25042cb21aff835 100644 (file)
@@ -4,7 +4,6 @@
   <selfvers>0</selfvers>
   <usedQMP/>
   <flag name='kvm'/>
-  <flag name='mem-path'/>
   <flag name='drive-serial'/>
   <flag name='sdl'/>
   <flag name='rtc'/>
index e1245953bd862bc1e3f473ae119ddc1aebc5934b..fdc6b4b73ff6c24ebbd4168822ea2ca96079fff2 100644 (file)
@@ -4,7 +4,6 @@
   <selfvers>0</selfvers>
   <usedQMP/>
   <flag name='kvm'/>
-  <flag name='mem-path'/>
   <flag name='drive-serial'/>
   <flag name='sdl'/>
   <flag name='rtc'/>
index 136385b8682492ffdf16db695a15ba5ae932bbff..a3a6400143dd621234cc38641daf7588687355f7 100644 (file)
@@ -4,7 +4,6 @@
   <selfvers>0</selfvers>
   <usedQMP/>
   <flag name='kvm'/>
-  <flag name='mem-path'/>
   <flag name='drive-serial'/>
   <flag name='sdl'/>
   <flag name='rtc'/>
index 76c6ab2a68810640aea602268e9e7a6086016282..c8e31f336cd3efac520cefe5fd3800dfac5f0aef 100644 (file)
@@ -4,7 +4,6 @@
   <selfvers>0</selfvers>
   <usedQMP/>
   <flag name='kvm'/>
-  <flag name='mem-path'/>
   <flag name='drive-serial'/>
   <flag name='sdl'/>
   <flag name='rtc'/>
index 2d16d41333b6ff00ba5f23f5d1d452a2f2c4aa4a..3c4452f7eefe29a2b99fbda1dc9389d6f7638bb9 100644 (file)
@@ -4,7 +4,6 @@
   <selfvers>0</selfvers>
   <usedQMP/>
   <flag name='kvm'/>
-  <flag name='mem-path'/>
   <flag name='drive-serial'/>
   <flag name='sdl'/>
   <flag name='rtc'/>
index efe2d4ac4a50cebfb710c39aa5bc039825367f35..96ec062cfce3997c61ca4fa893339ad475b82e9c 100644 (file)
@@ -4,7 +4,6 @@
   <selfvers>0</selfvers>
   <usedQMP/>
   <flag name='kvm'/>
-  <flag name='mem-path'/>
   <flag name='drive-serial'/>
   <flag name='sdl'/>
   <flag name='rtc'/>
index 7445253c417d73647737c2b1699e5745e8dd9c48..0ed1ab5c53c750b4510647cdc193d3f6fc1fe28e 100644 (file)
@@ -4,7 +4,6 @@
   <selfvers>0</selfvers>
   <usedQMP/>
   <flag name='kvm'/>
-  <flag name='mem-path'/>
   <flag name='drive-serial'/>
   <flag name='sdl'/>
   <flag name='rtc'/>
index 4d8d246828c753bfd9cd640182852a3f62cc75e6..ac01f3d5a5cc7c5274ac33af6e67328e224b3504 100644 (file)
@@ -4,7 +4,6 @@
   <selfvers>0</selfvers>
   <usedQMP/>
   <flag name='kvm'/>
-  <flag name='mem-path'/>
   <flag name='drive-serial'/>
   <flag name='sdl'/>
   <flag name='rtc'/>
index 584ec787094a35499fdfe06e32424107ad7981e7..a78a6c35c54a748d0abf6175ee5c1d33b54a4718 100644 (file)
@@ -4,7 +4,6 @@
   <selfvers>0</selfvers>
   <usedQMP/>
   <flag name='kvm'/>
-  <flag name='mem-path'/>
   <flag name='drive-serial'/>
   <flag name='sdl'/>
   <flag name='rtc'/>
index cee011d5f43c6417d67831dfeb6b9055ce7bf4ea..15516df5f64e4a5c9dc8fa9b1509efa995f08d14 100644 (file)
@@ -4,7 +4,6 @@
   <selfvers>0</selfvers>
   <usedQMP/>
   <flag name='kvm'/>
-  <flag name='mem-path'/>
   <flag name='drive-serial'/>
   <flag name='sdl'/>
   <flag name='rtc'/>
index e4060518b339269188f153f384e81c035aec43de..ee820d252b4cb93974c80a2e47a4f47c47344d5d 100644 (file)
@@ -4,7 +4,6 @@
   <selfvers>0</selfvers>
   <usedQMP/>
   <flag name='kvm'/>
-  <flag name='mem-path'/>
   <flag name='drive-serial'/>
   <flag name='sdl'/>
   <flag name='rtc'/>
index 6ad3e2b17b5dcff4e161ed94b0a85360e57d5206..d9ba0e19c32d7dbc49b96eb7c21849056b7eabb3 100644 (file)
@@ -4,7 +4,6 @@
   <selfvers>0</selfvers>
   <usedQMP/>
   <flag name='kvm'/>
-  <flag name='mem-path'/>
   <flag name='drive-serial'/>
   <flag name='sdl'/>
   <flag name='rtc'/>
index 3210e7ae005a2083b19e5b461cbc3c37ff673caa..78754199c896252bceef3783c2d0d5cc63879794 100644 (file)
@@ -866,7 +866,7 @@ mymain(void)
     DO_TEST("pmu-feature", NONE);
     DO_TEST("pmu-feature-off", NONE);
 
-    DO_TEST("hugepages", QEMU_CAPS_MEM_PATH);
+    DO_TEST("hugepages", NONE);
     DO_TEST("hugepages-numa", QEMU_CAPS_RTC,
             QEMU_CAPS_PIIX_DISABLE_S3, QEMU_CAPS_PIIX_DISABLE_S4,
             QEMU_CAPS_VIRTIO_SCSI,
@@ -875,23 +875,23 @@ mymain(void)
             QEMU_CAPS_DEVICE_QXL,
             QEMU_CAPS_HDA_DUPLEX, QEMU_CAPS_USB_REDIR,
             QEMU_CAPS_DEVICE_PC_DIMM,
-            QEMU_CAPS_MEM_PATH, QEMU_CAPS_OBJECT_MEMORY_FILE);
-    DO_TEST_LINUX("hugepages-pages", QEMU_CAPS_MEM_PATH,
+            QEMU_CAPS_OBJECT_MEMORY_FILE);
+    DO_TEST_LINUX("hugepages-pages",
                   QEMU_CAPS_OBJECT_MEMORY_RAM,
                   QEMU_CAPS_OBJECT_MEMORY_FILE);
-    DO_TEST("hugepages-pages2", QEMU_CAPS_MEM_PATH, QEMU_CAPS_OBJECT_MEMORY_RAM,
+    DO_TEST("hugepages-pages2", QEMU_CAPS_OBJECT_MEMORY_RAM,
             QEMU_CAPS_OBJECT_MEMORY_FILE);
-    DO_TEST("hugepages-pages3", QEMU_CAPS_MEM_PATH, QEMU_CAPS_OBJECT_MEMORY_RAM,
+    DO_TEST("hugepages-pages3", QEMU_CAPS_OBJECT_MEMORY_RAM,
             QEMU_CAPS_OBJECT_MEMORY_FILE);
-    DO_TEST_LINUX("hugepages-shared", QEMU_CAPS_MEM_PATH,
+    DO_TEST_LINUX("hugepages-shared",
                   QEMU_CAPS_OBJECT_MEMORY_RAM,
                   QEMU_CAPS_OBJECT_MEMORY_FILE);
     DO_TEST_PARSE_ERROR("hugepages-memaccess-invalid", NONE);
-    DO_TEST_FAILURE("hugepages-pages4", QEMU_CAPS_MEM_PATH,
+    DO_TEST_FAILURE("hugepages-pages4",
             QEMU_CAPS_OBJECT_MEMORY_RAM, QEMU_CAPS_OBJECT_MEMORY_FILE);
-    DO_TEST("hugepages-pages5", QEMU_CAPS_MEM_PATH);
+    DO_TEST("hugepages-pages5", NONE);
     DO_TEST("hugepages-pages6", NONE);
-    DO_TEST("hugepages-pages7", QEMU_CAPS_MEM_PATH,
+    DO_TEST("hugepages-pages7",
             QEMU_CAPS_DEVICE_PC_DIMM, QEMU_CAPS_OBJECT_MEMORY_FILE);
     DO_TEST("hugepages-memaccess", QEMU_CAPS_OBJECT_MEMORY_FILE,
             QEMU_CAPS_OBJECT_MEMORY_RAM, QEMU_CAPS_DEVICE_PC_DIMM,
@@ -899,7 +899,7 @@ mymain(void)
     DO_TEST("hugepages-memaccess2", QEMU_CAPS_OBJECT_MEMORY_FILE,
             QEMU_CAPS_OBJECT_MEMORY_RAM, QEMU_CAPS_DEVICE_PC_DIMM,
             QEMU_CAPS_NUMA);
-    DO_TEST_FAILURE("hugepages-memaccess3", QEMU_CAPS_MEM_PATH,
+    DO_TEST_FAILURE("hugepages-memaccess3",
             QEMU_CAPS_OBJECT_MEMORY_RAM, QEMU_CAPS_OBJECT_MEMORY_FILE,
             QEMU_CAPS_VIRTIO_SCSI);
     DO_TEST("nosharepages", QEMU_CAPS_MACHINE_OPT, QEMU_CAPS_MEM_MERGE);
@@ -2956,14 +2956,14 @@ mymain(void)
             QEMU_CAPS_VIRTIO_PCI_IOMMU_PLATFORM,
             QEMU_CAPS_VIRTIO_PCI_ATS);
 
-    DO_TEST("fd-memory-numa-topology", QEMU_CAPS_MEM_PATH, QEMU_CAPS_OBJECT_MEMORY_FILE,
+    DO_TEST("fd-memory-numa-topology", QEMU_CAPS_OBJECT_MEMORY_FILE,
             QEMU_CAPS_KVM);
-    DO_TEST("fd-memory-numa-topology2", QEMU_CAPS_MEM_PATH, QEMU_CAPS_OBJECT_MEMORY_FILE,
+    DO_TEST("fd-memory-numa-topology2", QEMU_CAPS_OBJECT_MEMORY_FILE,
             QEMU_CAPS_KVM);
-    DO_TEST("fd-memory-numa-topology3", QEMU_CAPS_MEM_PATH, QEMU_CAPS_OBJECT_MEMORY_FILE,
+    DO_TEST("fd-memory-numa-topology3", QEMU_CAPS_OBJECT_MEMORY_FILE,
             QEMU_CAPS_KVM);
 
-    DO_TEST("fd-memory-no-numa-topology", QEMU_CAPS_MEM_PATH, QEMU_CAPS_OBJECT_MEMORY_FILE,
+    DO_TEST("fd-memory-no-numa-topology", QEMU_CAPS_OBJECT_MEMORY_FILE,
             QEMU_CAPS_KVM);
 
     DO_TEST("cpu-check-none", QEMU_CAPS_KVM);