]> xenbits.xensource.com Git - qemu-upstream-4.5-testing.git/commitdiff
iscsi: Don't set error if already set in iscsi_do_inquiry
authorFam Zheng <famz@redhat.com>
Fri, 4 Apr 2014 11:53:29 +0000 (19:53 +0800)
committerKevin Wolf <kwolf@redhat.com>
Fri, 4 Apr 2014 12:11:34 +0000 (14:11 +0200)
This eliminates the possible assertion failure in error_setg().

Signed-off-by: Fam Zheng <famz@redhat.com>
Reviewed-by: Paolo Bonzini <pbonzini@redhat.com>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
block/iscsi.c

index 21c18a39dcc6356edc094653c03982a85ce67ddc..64a509f8f43eedb815ada868ed02b9464b036d27 100644 (file)
@@ -1101,8 +1101,10 @@ static struct scsi_task *iscsi_do_inquiry(struct iscsi_context *iscsi, int lun,
     return task;
 
 fail:
-    error_setg(errp, "iSCSI: Inquiry command failed : %s",
-               iscsi_get_error(iscsi));
+    if (!error_is_set(errp)) {
+        error_setg(errp, "iSCSI: Inquiry command failed : %s",
+                   iscsi_get_error(iscsi));
+    }
     if (task != NULL) {
         scsi_free_scsi_task(task);
     }