db retry, bisection: Reset %jobs_created on db retry

%jobs_created is used for memoisation while populating the destination
flight.  We need to reset it when we restart flight construction,
because those jobs were created in the discarded transaction.

Otherwise we could create a flight with missing jobs.

Signed-off-by: Ian Jackson <Ian.Jackson@eu.citrix.com>

diff --git a/cs-bisection-step b/cs-bisection-step
index 4c715876bcf52c8c0257f4808fb52a8fe9061bb8..1d1962a937c88a31cba81777a2e7c6535c407571 100755 (executable)
--- a/cs-bisection-step
+++ b/cs-bisection-step
@@ -1286,6 +1286,7 @@ END
 
     db_retry($popflight,'constructing', $dbh_tests,[qw(flights)], sub {
         print STDERR "Populating $popflight...\n";
+       undef %jobs_created;
         preparejob($job, $latest_flight, 0);
         foreach my $hostspec (split /,/, $hosts) { # /
             $hostspec =~ m/=/;