lib/posix-fdio: Remove posix-fdtab dependency

This change removes the hard dependency on posix-fdtab, allowing
posix-fdio to be used with anonymous open file descriptions (i.e., raw
uk_ofiles). It remains selected as a soft dependency by default.
File descriptor related syscalls are now only provided if posix-fdtab is
also selected.

Signed-off-by: Andrei Tatar <andrei@unikraft.io>
Approved-by: Sergiu Moga <sergiu@unikraft.io>
Reviewed-by: Sergiu Moga <sergiu@unikraft.io>
GitHub-Closes: #1574

diff --git a/lib/posix-fdio/Config.uk b/lib/posix-fdio/Config.uk
index 8ceec3006c29f3ccb7690617141a053b75bb754c..3fd80bb9b3abef85ec95c2cdaa00990cfa634710 100644 (file)
--- a/lib/posix-fdio/Config.uk
+++ b/lib/posix-fdio/Config.uk
@@ -5,5 +5,5 @@ config LIBPOSIX_FDIO
        select LIBPOSIX_FD
        select LIBPOSIX_TIME
        select LIBUKTIMECONV
-       select LIBPOSIX_FDTAB
-       select LIBPOSIX_FDTAB_LEGACY_SHIM
+       imply LIBPOSIX_FDTAB
+       select LIBPOSIX_FDTAB_LEGACY_SHIM if LIBPOSIX_FDTAB

diff --git a/lib/posix-fdio/Makefile.uk b/lib/posix-fdio/Makefile.uk
index 77dc27442a39455fc36d6c08624fdc8bc235f3e9..86b22f233a452a2f3aa2d2b06bd73009658d6044 100644 (file)
--- a/lib/posix-fdio/Makefile.uk
+++ b/lib/posix-fdio/Makefile.uk
@@ -6,7 +6,7 @@ CXXINCLUDES-$(CONFIG_LIBPOSIX_FDIO) += -I$(LIBPOSIX_FDIO_BASE)/include
 LIBPOSIX_FDIO_SRCS-y += $(LIBPOSIX_FDIO_BASE)/fdio.c
 LIBPOSIX_FDIO_SRCS-y += $(LIBPOSIX_FDIO_BASE)/fdstat.c
 LIBPOSIX_FDIO_SRCS-y += $(LIBPOSIX_FDIO_BASE)/fdctl.c
-LIBPOSIX_FDIO_SRCS-y += $(LIBPOSIX_FDIO_BASE)/fd-shim.c
+LIBPOSIX_FDIO_SRCS-$(CONFIG_LIBPOSIX_FDTAB) += $(LIBPOSIX_FDIO_BASE)/fd-shim.c
 
 UK_PROVIDED_SYSCALLS-$(CONFIG_LIBPOSIX_FDIO) += preadv2-5
 UK_PROVIDED_SYSCALLS-$(CONFIG_LIBPOSIX_FDIO) += preadv-4