]> xenbits.xensource.com Git - libvirt.git/commitdiff
xenconfig: add default in xenParseXLDisk()'s switches
authorCédric Bosdonnat <cbosdonnat@suse.com>
Wed, 14 Dec 2016 16:06:26 +0000 (17:06 +0100)
committerCédric Bosdonnat <cbosdonnat@suse.com>
Wed, 14 Dec 2016 17:02:58 +0000 (18:02 +0100)
Without a default: case in the switches in xenParseXLDisk(), build
would fail with every new disk backend or image format added in libxl,
as this is the case in this error:

http://logs.test-lab.xenproject.org/osstest/logs/103325/build-amd64-libvirt/5.ts-libvirt-build.log

src/xenconfig/xen_xl.c

index bcdd355276587224fd46bcb5cb23a93c68d9fb92..ffdf798e1c7f4bbe6587099bbdc3d7735fabdb06 100644 (file)
@@ -393,6 +393,12 @@ xenParseXLDisk(virConfPtr conf, virDomainDefPtr def)
 
                 case LIBXL_DISK_FORMAT_EMPTY:
                     break;
+
+                default:
+                    virReportError(VIR_ERR_CONFIG_UNSUPPORTED,
+                                   _("disk image format not supported: %s"),
+                                   libxl_disk_format_to_string(libxldisk->format));
+                    goto fail;
                 }
 
                 switch (libxldisk->backend) {
@@ -415,6 +421,11 @@ xenParseXLDisk(virConfPtr conf, virDomainDefPtr def)
                         goto fail;
                     virDomainDiskSetType(disk, VIR_STORAGE_TYPE_BLOCK);
                     break;
+                default:
+                    virReportError(VIR_ERR_CONFIG_UNSUPPORTED,
+                                   _("disk backend not supported: %s"),
+                                   libxl_disk_backend_to_string(libxldisk->backend));
+                    goto fail;
                 }
             }