]> xenbits.xensource.com Git - qemu-xen.git/commitdiff
hw/intc: fix default registers value in exynos4210_combiner_read()
authorChen Qun <kuhn.chenqun@huawei.com>
Thu, 27 Aug 2020 11:03:10 +0000 (19:03 +0800)
committerLaurent Vivier <laurent@vivier.eu>
Tue, 1 Sep 2020 10:05:21 +0000 (12:05 +0200)
Clang static code analyzer show warning:
hw/intc/exynos4210_combiner.c:231:9: warning: Value stored to 'val' is never read
        val = s->reg_set[offset >> 2];

The default register return value should be return 'val'.

Reported-by: Euler Robot <euler.robot@huawei.com>
Signed-off-by: Chen Qun <kuhn.chenqun@huawei.com>
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
Message-Id: <20200827110311.164316-10-kuhn.chenqun@huawei.com>
Signed-off-by: Laurent Vivier <laurent@vivier.eu>
hw/intc/exynos4210_combiner.c

index b8561e418037ef435bc6dd27ba9f5df1f3809964..59dd27fb16e53f26a1aa89b4ea4a51dd36934670 100644 (file)
@@ -229,7 +229,6 @@ exynos4210_combiner_read(void *opaque, hwaddr offset, unsigned size)
                     TARGET_FMT_plx "offset\n", offset);
         }
         val = s->reg_set[offset >> 2];
-        return 0;
     }
     return val;
 }