]> xenbits.xensource.com Git - libvirt.git/commitdiff
qemu_capabilities: Resolve Coverity NULL_RETURNS
authorJohn Ferlan <jferlan@redhat.com>
Wed, 27 Aug 2014 13:43:52 +0000 (09:43 -0400)
committerJohn Ferlan <jferlan@redhat.com>
Wed, 27 Aug 2014 16:52:54 +0000 (12:52 -0400)
Adjust the initialization of qemuCaps() to check for a NULL before
attempting to dereference like other callers/users do.

src/qemu/qemu_capabilities.c

index 410086b2c63590d4a19aa71c7ca6bb95c9c6c8b4..ce899f210d4affdc4aa24feb31135c2092171142 100644 (file)
@@ -3349,10 +3349,13 @@ virQEMUCapsPtr virQEMUCapsNewForBinary(const char *binary,
                                        uid_t runUid,
                                        gid_t runGid)
 {
-    virQEMUCapsPtr qemuCaps = virQEMUCapsNew();
+    virQEMUCapsPtr qemuCaps;
     struct stat sb;
     int rv;
 
+    if (!(qemuCaps = virQEMUCapsNew()))
+        goto error;
+
     if (VIR_STRDUP(qemuCaps->binary, binary) < 0)
         goto error;