]> xenbits.xensource.com Git - libvirt.git/commitdiff
qemu: Fix FD leak in qemudStartVMDaemon
authorMatthias Bolte <matthias.bolte@googlemail.com>
Wed, 17 Mar 2010 21:21:03 +0000 (22:21 +0100)
committerMatthias Bolte <matthias.bolte@googlemail.com>
Thu, 18 Mar 2010 22:45:11 +0000 (23:45 +0100)
The logfile FD is dup2'ed in __virExec in the child. The FD needs to
be closed in the parent, otherwise it leaks.

src/qemu/qemu_driver.c

index 67d9aded7cbce1fea5bedd3188f03f076040b681..a3aae33c8ba14539f1229347a77b0988d4b89007 100644 (file)
@@ -2975,6 +2975,9 @@ static int qemudStartVMDaemon(virConnectPtr conn,
     if (virDomainSaveStatus(driver->caps, driver->stateDir, vm) < 0)
         goto abort;
 
+    if (logfile != -1)
+        close(logfile);
+
     return 0;
 
 cleanup: