]> xenbits.xensource.com Git - osstest.git/commitdiff
osstest: explicitly set either enable or disable qemu-traditional
authorJuergen Gross <jgross@suse.com>
Tue, 26 Oct 2021 13:56:45 +0000 (15:56 +0200)
committerIan Jackson <iwj@xenproject.org>
Tue, 26 Oct 2021 15:03:43 +0000 (16:03 +0100)
Instead of setting "--enable-qemu-traditional" or not, switch to
setting "--enable-qemu-traditional" or "--disable-qemu-traditional".

This avoids a latent bug in the disable case, as the availability
of the option is tested via grep, which will otherwise grep for
nothing.

Reported-by: Ian Jackson <iwj@xenproject.org>
Signed-off-by: Juergen Gross <jgross@suse.com>
Reviewed-by: Ian Jackson <iwj@xenproject.org>
Release-Acked-by: Ian Jackson <iwj@xenproject.org>
ts-xen-build

index fdf555213c568a29657ce1a059cfad8e40c9ce8d..ccb2aba2313c23ddefd142f071f1ec002ed07769 100755 (executable)
@@ -144,7 +144,7 @@ END
 sub build () {
     my $xend_opt= $r{enable_xend} =~ m/true/ ? "--enable-xend" : "--disable-xend";
     my $ovmf_opt= $r{enable_ovmf} =~ m/true/ ? "--enable-ovmf" : "--disable-ovmf";
-    my $qemutrad_opt = $r{arch} =~ m/amd64|i386/ ? "--enable-qemu-traditional" : "";
+    my $qemutrad_opt = $r{arch} =~ m/amd64|i386/ ? "--enable-qemu-traditional" : "--disable-qemu-traditional";
 
     my $configure_prefix = $r{cmdprefix_configure} // '';
     my $configure_suffix = $r{cmdsuffix_configure} // '';