]> xenbits.xensource.com Git - people/royger/xen.git/commitdiff
xz: add fall-through comments to a switch statement
authorLasse Collin <lasse.collin@tukaani.org>
Mon, 7 Mar 2022 08:05:44 +0000 (09:05 +0100)
committerJan Beulich <jbeulich@suse.com>
Mon, 7 Mar 2022 08:05:44 +0000 (09:05 +0100)
It's good style. I was also told that GCC 7 is more strict and might
give a warning when such comments are missing.

Suggested-by: Andrei Borzenkov <arvidjaar@gmail.com>
Signed-off-by: Lasse Collin <lasse.collin@tukaani.org>
Signed-off-by: Jiri Kosina <jkosina@suse.cz>
Origin: git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git 5a244f48ecbb
Signed-off-by: Jan Beulich <jbeulich@suse.com>
Reviewed-by: Luca Fancellu <luca.fancellu@arm.com>
Acked-by: Andrew Cooper <andrew.cooper3@citrix.com>
xen/common/xz/dec_stream.c

index b7a8c15c5bb59d48cfbe2ab5c1f74f6a7b5f3b7d..672c57fac90fdd902b1a5ef44ecf1bebc9f92858 100644 (file)
@@ -583,6 +583,8 @@ static enum xz_ret __init dec_main(struct xz_dec *s, struct xz_buf *b)
                        if (ret != XZ_OK)
                                return ret;
 
+               /* Fall through */
+
                case SEQ_BLOCK_START:
                        /* We need one byte of input to continue. */
                        if (b->in_pos == b->in_size)
@@ -606,6 +608,8 @@ static enum xz_ret __init dec_main(struct xz_dec *s, struct xz_buf *b)
                        s->temp.pos = 0;
                        s->sequence = SEQ_BLOCK_HEADER;
 
+               /* Fall through */
+
                case SEQ_BLOCK_HEADER:
                        if (!fill_temp(s, b))
                                return XZ_OK;
@@ -616,6 +620,8 @@ static enum xz_ret __init dec_main(struct xz_dec *s, struct xz_buf *b)
 
                        s->sequence = SEQ_BLOCK_UNCOMPRESS;
 
+               /* Fall through */
+
                case SEQ_BLOCK_UNCOMPRESS:
                        ret = dec_block(s, b);
                        if (ret != XZ_STREAM_END)
@@ -623,6 +629,8 @@ static enum xz_ret __init dec_main(struct xz_dec *s, struct xz_buf *b)
 
                        s->sequence = SEQ_BLOCK_PADDING;
 
+               /* Fall through */
+
                case SEQ_BLOCK_PADDING:
                        /*
                         * Size of Compressed Data + Block Padding
@@ -643,6 +651,8 @@ static enum xz_ret __init dec_main(struct xz_dec *s, struct xz_buf *b)
 
                        s->sequence = SEQ_BLOCK_CHECK;
 
+               /* Fall through */
+
                case SEQ_BLOCK_CHECK:
                        if (s->check_type == XZ_CHECK_CRC32) {
                                ret = crc32_validate(s, b);
@@ -665,6 +675,8 @@ static enum xz_ret __init dec_main(struct xz_dec *s, struct xz_buf *b)
 
                        s->sequence = SEQ_INDEX_PADDING;
 
+               /* Fall through */
+
                case SEQ_INDEX_PADDING:
                        while ((s->index.size + (b->in_pos - s->in_start))
                                        & 3) {
@@ -687,6 +699,8 @@ static enum xz_ret __init dec_main(struct xz_dec *s, struct xz_buf *b)
 
                        s->sequence = SEQ_INDEX_CRC32;
 
+               /* Fall through */
+
                case SEQ_INDEX_CRC32:
                        ret = crc32_validate(s, b);
                        if (ret != XZ_STREAM_END)
@@ -695,6 +709,8 @@ static enum xz_ret __init dec_main(struct xz_dec *s, struct xz_buf *b)
                        s->temp.size = STREAM_HEADER_SIZE;
                        s->sequence = SEQ_STREAM_FOOTER;
 
+               /* Fall through */
+
                case SEQ_STREAM_FOOTER:
                        if (!fill_temp(s, b))
                                return XZ_OK;