]> xenbits.xensource.com Git - libvirt.git/commitdiff
build: avoid uninitialized use warning
authorEric Blake <eblake@redhat.com>
Fri, 26 Jul 2013 22:37:55 +0000 (16:37 -0600)
committerEric Blake <eblake@redhat.com>
Fri, 26 Jul 2013 22:44:06 +0000 (16:44 -0600)
Otherwise, with new enough gcc compiling at -O2, the build fails with:
../../src/conf/domain_conf.c: In function ‘virDomainDeviceDefPostParse’:
../../src/conf/domain_conf.c:2821:29: error: ‘cnt’ may be used uninitialized in this function [-Werror=maybe-uninitialized]
             for (i = 0; i < *cnt; i++) {
                             ^
../../src/conf/domain_conf.c:2795:20: note: ‘cnt’ was declared here
         size_t i, *cnt;
                    ^
../../src/conf/domain_conf.c:2794:30: error: ‘arrPtr’ may be used uninitialized in this function [-Werror=maybe-uninitialized]
         virDomainChrDefPtr **arrPtr;
                              ^

* src/conf/domain_conf.c (virDomainChrGetDomainPtrs): Always
assign into output parameters.

Signed-off-by: Eric Blake <eblake@redhat.com>
src/conf/domain_conf.c

index 0e74039d380c1493f3226313812ba7455558a3dc..a86be8c4391fee6240cea3364130bdb059aca8db 100644 (file)
@@ -10221,6 +10221,8 @@ virDomainChrGetDomainPtrs(virDomainDefPtr vmdef,
         break;
 
     case VIR_DOMAIN_CHR_DEVICE_TYPE_LAST:
+        *arrPtr = NULL;
+        *cntPtr = NULL;
         break;
     }
 }