]> xenbits.xensource.com Git - people/liuw/libxenctrl-split/libvirt.git/commitdiff
Really fix XML formatting flags in SaveImageUpdateDef
authorJán Tomko <jtomko@redhat.com>
Fri, 27 Feb 2015 10:55:40 +0000 (11:55 +0100)
committerJán Tomko <jtomko@redhat.com>
Fri, 27 Feb 2015 11:01:31 +0000 (12:01 +0100)
Commit cf2d4c6 used a logical or instead of bitwise or,
effectively passing 1, that is VIR_DOMAIN_XML_INACTIVE.

This was caught by a warning when building with clang.

https://bugzilla.redhat.com/show_bug.cgi?id=1183869

src/qemu/qemu_driver.c

index e9aa0b5feeb0d8efc1a293af12385976cfea2e80..e2824643f00ca5925b239b91d97598d500bbd7c6 100644 (file)
@@ -5734,7 +5734,7 @@ qemuDomainSaveImageUpdateDef(virQEMUDriverPtr driver,
 
     if (!(newdef_migr = qemuDomainDefCopy(driver,
                                           newdef,
-                                          QEMU_DOMAIN_FORMAT_LIVE_FLAGS ||
+                                          QEMU_DOMAIN_FORMAT_LIVE_FLAGS |
                                           VIR_DOMAIN_XML_MIGRATABLE)))
         goto cleanup;