]> xenbits.xensource.com Git - people/aperard/xen-arm.git/commitdiff
AMD IOMMU: add locking missing from c/s 26198:ba90ecb0231f
authorJan Beulich <jbeulich@suse.com>
Fri, 30 Nov 2012 10:42:55 +0000 (11:42 +0100)
committerJan Beulich <jbeulich@suse.com>
Fri, 30 Nov 2012 10:42:55 +0000 (11:42 +0100)
An oversight of mine; I'm sorry.

Signed-off-by: Jan Beulich <jbeulich@suse.com>
Acked-by: Ian Campbell <ian.campbell@citrix.com>
xen/drivers/passthrough/amd/iommu_init.c

index 82ce9679a7c757019a7880cfa4656e64471b22c0..1cbdda344ae9572151ff42badd5088ee24a7f0f4 100644 (file)
@@ -795,6 +795,7 @@ static bool_t __init set_iommu_interrupt_handler(struct amd_iommu *iommu)
 static void enable_iommu(struct amd_iommu *iommu)
 {
     unsigned long flags;
+    struct irq_desc *desc;
 
     spin_lock_irqsave(&iommu->lock, flags);
 
@@ -812,7 +813,11 @@ static void enable_iommu(struct amd_iommu *iommu)
     if ( iommu_has_feature(iommu, IOMMU_EXT_FEATURE_PPRSUP_SHIFT) )
         register_iommu_ppr_log_in_mmio_space(iommu);
 
-    set_msi_affinity(irq_to_desc(iommu->msi.irq), &cpu_online_map);
+    desc = irq_to_desc(iommu->msi.irq);
+    spin_lock(&desc->lock);
+    set_msi_affinity(desc, &cpu_online_map);
+    spin_unlock(&desc->lock);
+
     amd_iommu_msi_enable(iommu, IOMMU_CONTROL_ENABLED);
 
     set_iommu_ht_flags(iommu);