]> xenbits.xensource.com Git - libvirt.git/commitdiff
util: buffer: Encode URIs with upper case hex characters
authorPeter Krempa <pkrempa@redhat.com>
Thu, 24 Oct 2019 11:26:16 +0000 (13:26 +0200)
committerPeter Krempa <pkrempa@redhat.com>
Thu, 24 Oct 2019 17:35:34 +0000 (19:35 +0200)
rfc3986 uses uppercase characters so switch to using them as well.

Signed-off-by: Peter Krempa <pkrempa@redhat.com>
Reviewed-by: Ján Tomko <jtomko@redhat.com>
src/util/virbuffer.c
tests/viruritest.c

index bde118a248fa44d76cbc45b1e8e2a70625d37acc..2256bd5de5625c87ddd2c31e57e03d806565bbd7 100644 (file)
@@ -663,7 +663,7 @@ virBufferURIEncodeString(virBufferPtr buf, const char *str)
     int grow_size = 0;
     const char *p;
     unsigned char uc;
-    const char *hex = "0123456789abcdef";
+    const char *hex = "0123456789ABCDEF";
 
     if ((buf == NULL) || (str == NULL))
         return;
index a11587e52ba40983d8194769d8032172383b954b..07cf7261d1ced2c733d2fa28530e3ebc69b8d184 100644 (file)
@@ -184,7 +184,7 @@ mymain(void)
         { NULL, NULL, false },
     };
     TEST_FULL("spice://[3ffe::104]:5900/?tlsSubject=C=XX,L=Testtown,O=Test%20Company,CN=tester.test",
-              "spice://[3ffe::104]:5900/?tlsSubject=C%3dXX%2cL%3dTesttown%2cO%3dTest%20Company%2cCN%3dtester.test",
+              "spice://[3ffe::104]:5900/?tlsSubject=C%3DXX%2CL%3DTesttown%2CO%3DTest%20Company%2CCN%3Dtester.test",
               "spice", "3ffe::104", 5900, "/", "tlsSubject=C=XX,L=Testtown,O=Test%20Company,CN=tester.test", NULL, NULL, spiceparams);
 
     virURIParam params1[] = {