]> xenbits.xensource.com Git - qemu-xen.git/commitdiff
include/hw: document vhost_dev feature life-cycle
authorAlex Bennée <alex.bennee@linaro.org>
Tue, 2 Aug 2022 09:49:54 +0000 (10:49 +0100)
committerMichael S. Tsirkin <mst@redhat.com>
Fri, 7 Oct 2022 13:41:51 +0000 (09:41 -0400)
Try and explicitly document the various state of feature bits as
related to the vhost_dev structure. Importantly the backend_features
can advertise things like VHOST_USER_F_PROTOCOL_FEATURES which is
never exposed to the driver and is only present in the vhost-user
feature negotiation.

Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
Acked-by: Jason Wang <jasowang@redhat.com>
Message-Id: <20220802095010.3330793-7-alex.bennee@linaro.org>
Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
include/hw/virtio/vhost.h

index a346f23d13c25ebd50f0a9add266fb02ee402560..586c5457e2a1b5e6ab5ee9717bd214719a9f8329 100644 (file)
@@ -86,8 +86,11 @@ struct vhost_dev {
     /* if non-zero, minimum required value for max_queues */
     int num_queues;
     uint64_t features;
+    /** @acked_features: final set of negotiated features */
     uint64_t acked_features;
+    /** @backend_features: backend specific feature bits */
     uint64_t backend_features;
+    /** @protocol_features: final negotiated protocol features */
     uint64_t protocol_features;
     uint64_t max_queues;
     uint64_t backend_cap;