]> xenbits.xensource.com Git - libvirt.git/commitdiff
tests: Check for virQEMUDriverConfigNew return value
authorMichal Privoznik <mprivozn@redhat.com>
Mon, 26 Jan 2015 16:09:36 +0000 (17:09 +0100)
committerMichal Privoznik <mprivozn@redhat.com>
Mon, 26 Jan 2015 16:34:33 +0000 (17:34 +0100)
The function may return NULL if something went wrong. In some places
in the tests we are not checking the return value rather than
accessing the pointer directly resulting in SIGSEGV.

Signed-off-by: Michal Privoznik <mprivozn@redhat.com>
tests/domaincapstest.c
tests/qemuhotplugtest.c
tests/qemuxmlnstest.c

index 70d2ef37370c1bdb0d81208ca2187439c41e2b8b..fa931f6b028364c046413ef30ae077aafc6d7723 100644 (file)
@@ -231,6 +231,9 @@ mymain(void)
 
     virQEMUDriverConfigPtr cfg = virQEMUDriverConfigNew(false);
 
+    if (!cfg)
+        return EXIT_FAILURE;
+
 # define DO_TEST_QEMU(Filename, QemuCapsFile, Emulatorbin, Machine, Arch, Type, ...)    \
     do {                                                                                \
         const char *capsPath = abs_srcdir "/qemucapabilitiesdata/" QemuCapsFile ".caps";    \
index 1c18dbbc44ae0a28307f5b16ed258d1a2866de06..12a7f719b248ec2049234c0ff69b7a1c6c073339 100644 (file)
@@ -348,7 +348,8 @@ mymain(void)
 
     virEventRegisterDefaultImpl();
 
-    driver.config = virQEMUDriverConfigNew(false);
+    if (!(driver.config = virQEMUDriverConfigNew(false)))
+        return EXIT_FAILURE;
     VIR_FREE(driver.config->spiceListen);
     VIR_FREE(driver.config->vncListen);
     /* some dummy values from 'config file' */
index 947aa9ce0744d0933aa28778fe0c0bb0c8906d0d..4d665dae9120c6cbbce07dbf6992f4df7f88bee4 100644 (file)
@@ -211,7 +211,8 @@ mymain(void)
     if (!abs_top_srcdir)
         abs_top_srcdir = abs_srcdir "/..";
 
-    driver.config = virQEMUDriverConfigNew(false);
+    if (!(driver.config = virQEMUDriverConfigNew(false)))
+        return EXIT_FAILURE;
     if ((driver.caps = testQemuCapsInit()) == NULL)
         return EXIT_FAILURE;
     if (!(driver.xmlopt = virQEMUDriverCreateXMLConf(&driver)))