Fix release of virNetMessagePtr instances in streams processing

If a message packet for a invalid stream is received it is just
free'd. This is not good because it doesn't let the client RPC
request counter decrement. If a stream is shutdown with pending
packets the message also isn't released properly because of an
incorrect header type

* daemon/stream.c: Fix message header type
* src/rpc/virnetserverprogram.c: Send dummy reply instead of
  free'ing ignored stream message

diff --git a/daemon/stream.c b/daemon/stream.c
index 685cee2e0fa45ddd3dadfcc268eb7f77b371f102..56d79c2b6cbd7cf19b2b1bd9e4c0565e7a7c05a8 100644 (file)
--- a/daemon/stream.c
+++ b/daemon/stream.c
@@ -327,6 +327,7 @@ int daemonFreeClientStream(virNetServerClientPtr client,
         virNetMessagePtr tmp = msg->next;
         /* Send a dummy reply to free up 'msg' & unblock client rx */
         memset(msg, 0, sizeof(*msg));
+        msg->header.type = VIR_NET_REPLY;
         if (virNetServerClientSendMessage(client, msg) < 0) {
             virNetServerClientMarkClose(client);
             virNetMessageFree(msg);

diff --git a/src/rpc/virnetserverprogram.c b/src/rpc/virnetserverprogram.c
index 4afed64c6e118f837d5a18ff20e1d6eba23f2321..ca80ae09ed845ce660c55f6bdb59a53c6186ad61 100644 (file)
--- a/src/rpc/virnetserverprogram.c
+++ b/src/rpc/virnetserverprogram.c
@@ -259,7 +259,13 @@ int virNetServerProgramDispatch(virNetServerProgramPtr prog,
          */
         VIR_INFO("Ignoring unexpected stream data serial=%d proc=%d status=%d",
                  msg->header.serial, msg->header.proc, msg->header.status);
-        virNetMessageFree(msg);
+        /* Send a dummy reply to free up 'msg' & unblock client rx */
+        memset(msg, 0, sizeof(*msg));
+        msg->header.type = VIR_NET_REPLY;
+        if (virNetServerClientSendMessage(client, msg) < 0) {
+            ret = -1;
+            goto cleanup;
+        }
         ret = 0;
         break;
 
@@ -275,6 +281,7 @@ int virNetServerProgramDispatch(virNetServerProgramPtr prog,
 error:
     ret = virNetServerProgramSendReplyError(prog, client, msg, &rerr, &msg->header);
 
+cleanup:
     return ret;
 }