]> xenbits.xensource.com Git - libvirt.git/commitdiff
daemon: Register secret driver before storage driver
authorMichal Privoznik <mprivozn@redhat.com>
Fri, 1 Mar 2019 14:48:53 +0000 (15:48 +0100)
committerMichal Privoznik <mprivozn@redhat.com>
Wed, 6 Mar 2019 09:20:31 +0000 (10:20 +0100)
The order in which drivers are registered is important because
their stateInitialize and stateAutoStart callback are called in
that order. Well, stateAutoStart is going away and therefore if
there is some dependency between two drivers (e.g. when
initializing storage driver expects secret driver to be available
already), the registration of such drivers must happen in correct
order.

Signed-off-by: Michal Privoznik <mprivozn@redhat.com>
Reviewed-by: Ján Tomko <jtomko@redhat.com>
src/remote/remote_daemon.c

index 54ddfc42a06fd6c39697c7b9e4f7fe0b3e388027..61eabe03be44d6e7ed5a301cf49f5e3d0c7021b9 100644 (file)
@@ -312,6 +312,10 @@ static int daemonInitialize(void)
     if (virDriverLoadModule("interface", "interfaceRegister", false) < 0)
         return -1;
 #endif
+#ifdef WITH_SECRETS
+    if (virDriverLoadModule("secret", "secretRegister", false) < 0)
+        return -1;
+#endif
 #ifdef WITH_STORAGE
     if (virDriverLoadModule("storage", "storageRegister", false) < 0)
         return -1;
@@ -320,10 +324,6 @@ static int daemonInitialize(void)
     if (virDriverLoadModule("nodedev", "nodedevRegister", false) < 0)
         return -1;
 #endif
-#ifdef WITH_SECRETS
-    if (virDriverLoadModule("secret", "secretRegister", false) < 0)
-        return -1;
-#endif
 #ifdef WITH_NWFILTER
     if (virDriverLoadModule("nwfilter", "nwfilterRegister", false) < 0)
         return -1;