PDU::ipmi: Better username/password configuration

This can now come from host properties, or failing that we use
ADMIN/ADMIN which seems common.

No functional change with working existing configs.

Signed-off-by: Ian Jackson <Ian.Jackson@eu.citrix.com>

diff --git a/Osstest/PDU/ipmi.pm b/Osstest/PDU/ipmi.pm
index 0cbc5b90a80b8d32792e169efb579edd01831c26..dbf211f7d7b6bb5d8fa36dfa14da7bacbb907da7 100644 (file)
--- a/Osstest/PDU/ipmi.pm
+++ b/Osstest/PDU/ipmi.pm
@@ -36,6 +36,8 @@ BEGIN {
 
 sub new {
     my ($class, $ho, $methname, $mgmt, $user, $pass, @opts) = @_;
+    $user ||= get_host_property($ho, 'IpmiUser') || 'ADMIN';
+    $pass ||= get_host_property($ho, 'IpmiPassword') || 'ADMIN';
     return bless { Host => $ho,
                   Mgmt => $mgmt,
                   User => $user,