]> xenbits.xensource.com Git - libvirt.git/commitdiff
vboxDumpDisplay: remove suspicious strlen
authorJán Tomko <jtomko@redhat.com>
Fri, 5 Feb 2016 16:46:07 +0000 (17:46 +0100)
committerJán Tomko <jtomko@redhat.com>
Tue, 9 Feb 2016 09:11:05 +0000 (10:11 +0100)
The return type of strlen is 'size_t', which is unsigned and therefore
never less than zero.

Use STREQ to make the check obvious.

src/vbox/vbox_common.c

index 72938e9f624c2c8548f5fb07242726ca181981d5..38813963dc2b5fe90b67ab7a7b5fd6737bb82ac7 100644 (file)
@@ -3336,7 +3336,7 @@ vboxDumpDisplay(virDomainDefPtr def, vboxGlobalData *data, IMachine *machine)
             VBOX_UTF16_TO_UTF8(valueDisplayUtf16, &valueDisplayUtf8);
             VBOX_UTF16_FREE(valueDisplayUtf16);
 
-            if (strlen(valueDisplayUtf8) <= 0)
+            if (STREQ(valueDisplayUtf8, ""))
                 VBOX_UTF8_FREE(valueDisplayUtf8);
         }